Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wrapper IsEqualSnapshotCreateStats #1680

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Add Wrapper IsEqualSnapshotCreateStats #1680

merged 2 commits into from
Oct 18, 2022

Conversation

r4rajat
Copy link
Contributor

@r4rajat r4rajat commented Oct 14, 2022 •
edited

Signed-off-by: Rajat Gupta rajat.gupta@veeam.com

Change Overview

Add Wrapper IsEqualSnapshotCreateStats in Kanister Kopia Package

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@r4rajat
Add Wrapper IsEqualSnapshotCreateStats
d257a7e 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Oct 14, 2022
ankitjain235
ankitjain235 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Oct 18, 2022
@r4rajat r4rajat added the kueue label Oct 18, 2022
@mergify mergify bot merged commit a0734ff into master Oct 18, 2022
Kanister automation moved this from Reviewer approved to Done Oct 18, 2022
@mergify mergify bot deleted the Add-Wrapper-IsEqualSnapshotCreateStats branch October 18, 2022 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitjain235 ankitjain235 ankitjain235 approved these changes

@shlokc9 shlokc9 Awaiting requested review from shlokc9

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r4rajat @ankitjain235