-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EnvironmentVariables to PodOptions #1690
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
does this effect the kanister functions, that support podOverride, somehow? |
Can you also mention why did we do this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@ankitjain235 possible to add unit test for this? |
651d926
to
1ec2471
Compare
1ec2471
to
a07569a
Compare
3872140
to
7ac380b
Compare
a07569a
to
2543e0f
Compare
2543e0f
to
147d483
Compare
147d483
to
743b22a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM 👍🏼
But, the branch has some merge conflict PTAL
@@ -109,6 +110,7 @@ func GetPodObjectFromPodOptions(cli kubernetes.Interface, opts *PodOptions) (*v1 | |||
ImagePullPolicy: v1.PullPolicy(v1.PullIfNotPresent), | |||
VolumeMounts: volumeMounts, | |||
Resources: opts.Resources, | |||
Env: opts.EnvironmentVariables, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankitjain235 Should we check for empty/nil before setting?
Change Overview
This PR adds EnvironmentVariables of type []v1.Env and SecretMounts of type map[string]string to be passed to PodOptions. SecretMounts is a map of secretTypeKeyName and secret name. For e.g., {"location": "test-location-secret"}
This was added so that location and secret information can be provided to the pod running kopia repository create/connect command.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan