Add EnvironmentVariables to PodOptions #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
shlokc9
approved these changes
Oct 18, 2022
|
does this effect the kanister functions, that support podOverride, somehow? |
|
Can you also mention why did we do this? |
|
@ankitjain235 possible to add unit test for this? |
ankitjain235
changed the title
ankitjain235
force-pushed
the
add-env-podoptions
branch
3 times, most recently
from
651d926
to
1ec2471
Compare
ankitjain235
force-pushed
the
add-env-podoptions
branch
from
1ec2471
to
a07569a
Compare
ankitjain235
force-pushed
the
kube-file-reader-util
branch
from
3872140
to
7ac380b
Compare
ankitjain235
force-pushed
the
add-env-podoptions
branch
from
a07569a
to
2543e0f
Compare
ankitjain235
force-pushed
the
add-env-podoptions
branch
from
2543e0f
to
147d483
Compare
ankitjain235
force-pushed
the
add-env-podoptions
branch
from
147d483
to
743b22a
Compare
shlokc9
approved these changes
Nov 3, 2022
ankitjain235
changed the title
shlokc9
approved these changes
Nov 11, 2022
pavannd1
reviewed
Nov 11, 2022
| @@ -109,6 +110,7 @@ func GetPodObjectFromPodOptions(cli kubernetes.Interface, opts *PodOptions) (*v1 | |||
| ImagePullPolicy: v1.PullPolicy(v1.PullIfNotPresent), | |||
| VolumeMounts: volumeMounts, | |||
| Resources: opts.Resources, | |||
| Env: opts.EnvironmentVariables, | |||
There was a problem hiding this comment.
@ankitjain235 Should we check for empty/nil before setting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR adds EnvironmentVariables of type []v1.Env and SecretMounts of type map[string]string to be passed to PodOptions. SecretMounts is a map of secretTypeKeyName and secret name. For e.g., {"location": "test-location-secret"}
This was added so that location and secret information can be provided to the pod running kopia repository create/connect command.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan