Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Missing Kopia Wrappers in Kanister #1693

Merged
merged 16 commits into from
Nov 14, 2022
Merged

Add Missing Kopia Wrappers in Kanister #1693

merged 16 commits into from
Nov 14, 2022

Conversation

r4rajat
Copy link
Contributor

@r4rajat r4rajat commented Oct 18, 2022 •
edited

Change Overview

Add Missing Kopia Wrappers in Kanister

  • Add wrapper for RepositoryStatusCommand
  • Add wrapper for GeneralCommand
  • Update Wrapper SnapshotCreate

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@r4rajat
Add RepositoryStatusCommand Wrapper for Kanister kopia package
406d62d 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Add GeneralCommand Wrapper for Kanister kopia package
c6c8a53 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Oct 18, 2022
@r4rajat
Fix ParseSnapshotManifestList naming
3b9d8da 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Add ProgressUpdateInterval in SnapshotCreate Wrapper
84e80df 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat r4rajat changed the title Add wrapper for RepositoryStatusCommand and GeneralCommand Add Missing Wrappers Oct 27, 2022
ankitjain235
ankitjain235 reviewed Oct 31, 2022
View reviewed changes
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Let's add tests for the utilities added.

r4rajat and others added 6 commits October 31, 2022 12:09
@r4rajat
Update comment
dd07067 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Merge remote-tracking branch 'origin/Add-Wrapper-RepositoryStatusComm…
eb01295 
…and-GeneralCommand' into Add-Wrapper-RepositoryStatusCommand-GeneralCommand
@r4rajat
Merge branch 'master' into Add-Wrapper-RepositoryStatusCommand-Genera…
38ae8d6 
…lCommand
@r4rajat
Merge branch 'master' into Add-Wrapper-RepositoryStatusCommand-Genera…
6caf56a 
…lCommand
@r4rajat
Merge branch 'master' into Add-Wrapper-RepositoryStatusCommand-Genera…
433678f 
…lCommand
@r4rajat
Update parse_command_output.go
42a747d 
Update ParseSnapshotManifestList with parseSnapshotManifestList
akankshakumari393
akankshakumari393 reviewed Nov 11, 2022
View reviewed changes
Copy link
Contributor

@akankshakumari393 akankshakumari393 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ankitjain235
ankitjain235 reviewed Nov 11, 2022
View reviewed changes
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, looks good otherwise.

pkg/kopia/command/common.go Outdated Show resolved Hide resolved
@r4rajat r4rajat changed the title Add Missing Wrappers Add Missing Kopia Wrappers in Kanister Nov 11, 2022
r4rajat and others added 4 commits November 11, 2022 20:48
@r4rajat
Merge branch 'master' into Add-Wrapper-RepositoryStatusCommand-Genera…
1844d7e 
…lCommand
@r4rajat
Export Function ParseSnapshotManifestList
b3ad38f 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Add Comment
fed63f1 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Remove KopiaCommandParams
6d94e6a 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
ankitjain235
ankitjain235 approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Nov 14, 2022
@r4rajat r4rajat added kueue and removed kueue labels Nov 14, 2022
@mergify mergify bot merged commit 332bc14 into master Nov 14, 2022
Kanister automation moved this from Reviewer approved to Done Nov 14, 2022
@mergify mergify bot deleted the Add-Wrapper-RepositoryStatusCommand-GeneralCommand branch November 14, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akankshakumari393 akankshakumari393 akankshakumari393 left review comments

@ankitjain235 ankitjain235 ankitjain235 approved these changes

@shlokc9 shlokc9 Awaiting requested review from shlokc9

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r4rajat @ankitjain235 @akankshakumari393