Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Name to PodOptions #1695

Merged
merged 5 commits into from
Oct 27, 2022
Merged

Add Name to PodOptions #1695

merged 5 commits into from
Oct 27, 2022

Conversation

kale-amruta
Copy link
Contributor

Change Overview

Add an option to have fixed name for a pod

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@akankshakumari393
Copy link
Contributor

LGTM

Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question, looks good otherwise.

pkg/kube/pod.go Show resolved Hide resolved
Kanister automation moved this from In Progress to Reviewer approved Oct 21, 2022
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment update. LG otherwise

pkg/kube/pod.go Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 1625355 into master Oct 27, 2022
Kanister automation moved this from Reviewer approved to Done Oct 27, 2022
@mergify mergify bot deleted the podOptions branch October 27, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants