-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kopia repository storage args generation utilities #1696
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
1ec2471
to
a07569a
Compare
57a8be7
to
bb13f1a
Compare
a07569a
to
2543e0f
Compare
bb13f1a
to
5b5cf34
Compare
2543e0f
to
147d483
Compare
5b5cf34
to
29b59e7
Compare
147d483
to
743b22a
Compare
6e13b37
to
5e6b2c4
Compare
5e6b2c4
to
d14afbe
Compare
c4a24f3
to
694ea2f
Compare
05f63e0
to
6714804
Compare
|
||
// GetMapForLocationValues return a map with valid keys | ||
// for different location values | ||
func GetMapForLocationValues( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What did we decide about the validation of the location secret? Is that something we'll add to the repo server controller?
cc: @kale-amruta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep them separate from these wrappers, at some higher level? We can avoid pod creation as well if validation fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should have some kinda validation definitely. Wanted to make sure we are aware of it 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Overview
This PR adds storage wrappers for generation arguments that will be used for repository commands.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan