Add kopia repository storage args generation utilities #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
PrasadG193
reviewed
Oct 21, 2022
ankitjain235
force-pushed
the
add-env-podoptions
branch
from
1ec2471
to
a07569a
Compare
ankitjain235
force-pushed
the
repo-storage-wrappers
branch
from
57a8be7
to
bb13f1a
Compare
ankitjain235
force-pushed
the
add-env-podoptions
branch
from
a07569a
to
2543e0f
Compare
ankitjain235
force-pushed
the
repo-storage-wrappers
branch
from
bb13f1a
to
5b5cf34
Compare
ankitjain235
force-pushed
the
add-env-podoptions
branch
from
2543e0f
to
147d483
Compare
ankitjain235
force-pushed
the
repo-storage-wrappers
branch
from
5b5cf34
to
29b59e7
Compare
ankitjain235
force-pushed
the
add-env-podoptions
branch
from
147d483
to
743b22a
Compare
ankitjain235
force-pushed
the
repo-storage-wrappers
branch
from
6e13b37
to
5e6b2c4
Compare
ankitjain235
force-pushed
the
repo-storage-wrappers
branch
from
5e6b2c4
to
d14afbe
Compare
ankitjain235
force-pushed
the
repo-storage-wrappers
branch
from
c4a24f3
to
694ea2f
Compare
ankitjain235
force-pushed
the
repo-storage-wrappers
branch
from
05f63e0
to
6714804
Compare
shlokc9
reviewed
Nov 3, 2022
pavannd1
reviewed
Nov 30, 2022
|
|
||
| // GetMapForLocationValues return a map with valid keys | ||
| // for different location values | ||
| func GetMapForLocationValues( |
There was a problem hiding this comment.
What did we decide about the validation of the location secret? Is that something we'll add to the repo server controller?
cc: @kale-amruta
There was a problem hiding this comment.
Should we keep them separate from these wrappers, at some higher level? We can avoid pod creation as well if validation fails.
There was a problem hiding this comment.
Yes, we should have some kinda validation definitely. Wanted to make sure we are aware of it 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR adds storage wrappers for generation arguments that will be used for repository commands.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan