Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker to build image #1697

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Add docker to build image #1697

merged 3 commits into from
Oct 21, 2022

Conversation

bathina2
Copy link
Contributor

Change Overview

After changing build image from alpine to debian, we need to install docker independently.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Oct 21, 2022
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will wait for @ankitjain235 to take a look

Kanister automation moved this from In Progress to Reviewer approved Oct 21, 2022
@mergify mergify bot merged commit 7eb4949 into master Oct 21, 2022
Kanister automation moved this from Reviewer approved to Done Oct 21, 2022
@mergify mergify bot deleted the add_docker_to_build_image branch October 21, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants