Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utilities to generate EnvVars for secret #1699

Merged
merged 26 commits into from
Dec 2, 2022
Merged

Conversation

ankitjain235
Copy link
Contributor

@ankitjain235 ankitjain235 commented Oct 21, 2022

Change Overview

This PR adds utilities for generating EnvVars for a secret. The EnvVars will be set for repository wrappers to provide credentials.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. We can make required changes for web identity token if required and then merge this

Kanister automation moved this from In Progress to Reviewer approved Nov 30, 2022
Base automatically changed from repo-storage-wrappers to master December 2, 2022 05:04
@ankitjain235 ankitjain235 added kueue and removed kueue labels Dec 2, 2022
@mergify mergify bot merged commit ecb708d into master Dec 2, 2022
Kanister automation moved this from Reviewer approved to Done Dec 2, 2022
@mergify mergify bot deleted the add-kopia-secret-utils branch December 2, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants