Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build kopia binary as part of kanister-tools #1711

Merged
merged 6 commits into from
Nov 11, 2022

Conversation

ankitjain235
Copy link
Contributor

Change Overview

This PR updates workflow to build Kopia binary as a part of Kanister-tools image build instead of a separate image.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

docker/tools/Dockerfile Outdated Show resolved Hide resolved
@julio-lopez
Copy link
Contributor

This is the right direction, there is no need for building kopia in a separate image and pushing it to a registry.

@ankitjain235 ankitjain235 force-pushed the update-kopia-binary-build-process branch from d48403a to a717cf2 Compare November 7, 2022 06:35
docker/tools/Dockerfile Outdated Show resolved Hide resolved
docker/tools/Dockerfile Outdated Show resolved Hide resolved
docker/tools/Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Nov 11, 2022
@pavannd1 pavannd1 merged commit 125a7a8 into master Nov 11, 2022
Kanister automation moved this from Reviewer approved to Done Nov 11, 2022
@pavannd1 pavannd1 deleted the update-kopia-binary-build-process branch November 11, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants