-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unit Tests for Kopia #1723
Add Unit Tests for Kopia #1723
Conversation
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
…opia-Unit-Tests # Conflicts: # pkg/kopia/command/blob_test.go
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat The ci seems to be failing here. |
# Conflicts: # pkg/kopia/command/const.go
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@@ -44,7 +40,6 @@ func SnapshotCreate(cmdArgs SnapshotCreateCommandArgs) []string { | |||
args := commonArgs(cmdArgs.CommandArgs, requireLogLevelInfo) | |||
args = args.AppendLoggable(snapshotSubCommand, createSubCommand, cmdArgs.PathToBackup, jsonFlag) | |||
args = args.AppendLoggableKV(parallelFlag, parallelismStr) | |||
args = args.AppendLoggableKV(progressUpdateIntervalFlag, longUpdateInterval) | |||
args = addTags(cmdArgs.Tags, args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this because it was already happening below in the function thus the --progress-update-interval
flag was getting set twice
DefaultConfigDirectory = "/tmp/kopia-repository" | ||
|
||
// DefaultLogDirectory is the directory where kopia log file is created | ||
DefaultLogDirectory = "/tmp/kopia-log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add these constants as these are being heavily used like kopia.DefaultConfigFilePath in implementation of wrappers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, LGTM.
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will let someone else also take a look before approving.
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Change Overview
Add Unit Tests for Kopia
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan