Add Unit Tests for Kopia #1723
Merged
Add Unit Tests for Kopia #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
…opia-Unit-Tests # Conflicts: # pkg/kopia/command/blob_test.go
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
r4rajat
changed the title
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
r4rajat
changed the title
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
|
@r4rajat The ci seems to be failing here. |
# Conflicts: # pkg/kopia/command/const.go
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
r4rajat
commented
Nov 15, 2022
| @@ -44,7 +40,6 @@ func SnapshotCreate(cmdArgs SnapshotCreateCommandArgs) []string { | |||
| args := commonArgs(cmdArgs.CommandArgs, requireLogLevelInfo) | |||
| args = args.AppendLoggable(snapshotSubCommand, createSubCommand, cmdArgs.PathToBackup, jsonFlag) | |||
| args = args.AppendLoggableKV(parallelFlag, parallelismStr) | |||
| args = args.AppendLoggableKV(progressUpdateIntervalFlag, longUpdateInterval) | |||
| args = addTags(cmdArgs.Tags, args) | |||
There was a problem hiding this comment.
Removed this because it was already happening below in the function thus the --progress-update-interval flag was getting set twice
r4rajat
commented
Nov 16, 2022
| DefaultConfigDirectory = "/tmp/kopia-repository" | ||
|
|
||
| // DefaultLogDirectory is the directory where kopia log file is created | ||
| DefaultLogDirectory = "/tmp/kopia-log" |
There was a problem hiding this comment.
Add these constants as these are being heavily used like kopia.DefaultConfigFilePath in implementation of wrappers
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
ankitjain235
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Add Unit Tests for Kopia
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan