Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct passing WebIdentity token to AWS provider #1724

Merged
merged 4 commits into from
Nov 10, 2022

Conversation

ed-shilo
Copy link
Contributor

@ed-shilo ed-shilo commented Nov 8, 2022

Change Overview

Allowing to pass Role ARN and Web Identity token for token-based AWS authentication.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Nov 8, 2022
@ed-shilo ed-shilo force-pushed the keu/ed-shilo/K10-13548-aws-webid-param branch from 34dba0e to eab96f3 Compare November 8, 2022 12:05
@ed-shilo ed-shilo marked this pull request as ready for review November 8, 2022 12:06
@ed-shilo ed-shilo changed the title [K10-13548] Direct passing WebIdentity token to AWS provider Direct passing WebIdentity token to AWS provider Nov 8, 2022
@denisvmedia denisvmedia removed their assignment Nov 8, 2022
pkg/aws/aws.go Outdated Show resolved Hide resolved
@viveksinghggits
Copy link
Contributor

LGTM overall.

pkg/aws/aws.go Show resolved Hide resolved
pkg/aws/aws.go Outdated Show resolved Hide resolved
pkg/aws/aws.go Outdated Show resolved Hide resolved
@ed-shilo ed-shilo force-pushed the keu/ed-shilo/K10-13548-aws-webid-param branch from f7bc592 to 14892dd Compare November 9, 2022 10:40
Kanister automation moved this from In Progress to Reviewer approved Nov 9, 2022
pkg/aws/aws.go Outdated Show resolved Hide resolved
@ed-shilo ed-shilo force-pushed the keu/ed-shilo/K10-13548-aws-webid-param branch from 14892dd to 987f4bd Compare November 10, 2022 06:24
@ed-shilo ed-shilo added the kueue label Nov 10, 2022
@mergify mergify bot merged commit ee171e8 into master Nov 10, 2022
Kanister automation moved this from Reviewer approved to Done Nov 10, 2022
@mergify mergify bot deleted the keu/ed-shilo/K10-13548-aws-webid-param branch November 10, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants