Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint to Restore Postgres data into RDS database Instance #1768

Merged
merged 22 commits into from
Apr 18, 2023

Conversation

akankshakumari393
Copy link
Contributor

@akankshakumari393 akankshakumari393 commented Dec 2, 2022

Change Overview

The blueprint is to restore postgres application data into RDS instance.

The Blueprint would assume RDS instance and security group to be already created

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Dec 2, 2022
@akankshakumari393 akankshakumari393 marked this pull request as ready for review December 7, 2022 09:17
@viveksinghggits
Copy link
Contributor

Was there an already raised PR for this? Because it looks like I have already reviewed the .md file.

@akankshakumari393 akankshakumari393 changed the title Blueprint Restore into provisioned RDS database instance Blueprint to Restore Postgres data into RDS database Instance Dec 8, 2022
Copy link
Member

@shuguet shuguet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes, and I agree with you, that's probably the best we can do given circumstances.
Thank you!

examples/postgres-RDS/README.md Outdated Show resolved Hide resolved
examples/postgres-RDS/README.md Outdated Show resolved Hide resolved
examples/postgres-RDS/README.md Outdated Show resolved Hide resolved
examples/postgres-RDS/README.md Outdated Show resolved Hide resolved
examples/postgres-RDS/README.md Outdated Show resolved Hide resolved
examples/postgres-RDS/rds-restore-blueprint.yaml Outdated Show resolved Hide resolved
examples/postgres-RDS/README.md Outdated Show resolved Hide resolved
examples/postgres-RDS/README.md Outdated Show resolved Hide resolved
examples/postgres-RDS/README.md Outdated Show resolved Hide resolved
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
examples/postgres-RDS/rds-restore-blueprint.yaml Outdated Show resolved Hide resolved
examples/postgres-RDS/README.md Outdated Show resolved Hide resolved
examples/postgres-RDS/README.md Outdated Show resolved Hide resolved
examples/postgres-RDS/README.md Outdated Show resolved Hide resolved
examples/postgres-RDS/README.md Show resolved Hide resolved
examples/postgres-RDS/README.md Outdated Show resolved Hide resolved
examples/postgres-RDS/README.md Show resolved Hide resolved
examples/postgres-RDS/rds-restore-blueprint.yaml Outdated Show resolved Hide resolved
examples/postgres-RDS/rds-restore-blueprint.yaml Outdated Show resolved Hide resolved
examples/postgres-RDS/rds-restore-blueprint.yaml Outdated Show resolved Hide resolved
Kanister automation moved this from In Progress to Review Required Apr 6, 2023
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
examples/postgres-RDS/README.md Outdated Show resolved Hide resolved
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Copy link
Contributor Author

Hi @viveksinghggits could you please take a look at the PR if you get a chance.

examples/postgres-RDS/README.md Outdated Show resolved Hide resolved
Kanister automation moved this from Review Required to Reviewer approved Apr 18, 2023
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@mergify mergify bot merged commit c5c86eb into master Apr 18, 2023
Kanister automation moved this from Reviewer approved to Done Apr 18, 2023
@mergify mergify bot deleted the provision_rds_instance branch April 18, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants