Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose AWS env vars for web identity token file #1774

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

leuyentran
Copy link
Contributor

Signed-off-by: Le Tran le.tran@kasten.io

AWS environment variables for Authentication with Web Identity Token are currently not exposed, therefore users of AWS auth from kanister needs to redefine these variables. This pattern is not transparent and error-prone if these variables change in the future.

This PR expose the variables for direct reference from callers.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Signed-off-by: Le Tran <le.tran@kasten.io>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Dec 7, 2022
Kanister automation moved this from In Progress to Reviewer approved Dec 7, 2022
@mergify mergify bot merged commit a41c00b into master Dec 7, 2022
@mergify mergify bot deleted the Expose-AWS-Env-Vars-for-Web-Identity-Token-File branch December 7, 2022 16:02
Kanister automation moved this from Reviewer approved to Done Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants