-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed steps for postgresql example #1779
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
99b0367
to
2870861
Compare
@@ -70,7 +70,7 @@ actions: | |||
name: deleteDump | |||
args: | |||
image: ghcr.io/kanisterio/postgres-kanister-tools:0.84.0 | |||
namespace: "{{ .Namespace.Name }}" | |||
namespace: "{{ .StatefulSet.Namespace }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
Also, I believe this blueprint is no longer relevant. We can remove the v10.16.2 and v8.6.4 folders completely. @viveksinghggits @PrasadG193 WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, maybe I am missing some context. Why this blueprint not relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@viveksinghggits are there any specific uses for this blueprint? Do we need to support this particular version of postgres?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have to support that specific version. But I think it's ok to keep the stale versions of blueprint just for future reference. if someone wants to refer to specific postgres' versions blueprint.
I think this is the reason we decided to have these dirs with older blueprints right?
I am also ok if decide to remove them.
31cc082
to
75c81f6
Compare
a82af0d
to
fac2bb4
Compare
- fixed kanctl installation link - updated responses for actionset
fac2bb4
to
5bfd415
Compare
FROM postgres:14-bullseye | ||
|
||
LABEL maintainer="vkamra@kasten.io" | ||
FROM postgres:15-bullseye |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow-up, we should remove this Dockerfile and stop building this image through goreleaser. I don't think we use this anymore
Change Overview
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan