Fixed steps for postgresql example #1779
Conversation
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
shahpratikr
force-pushed
the
fix_postgresql_readme
branch
from
99b0367
to
2870861
Compare
| @@ -70,7 +70,7 @@ actions: | |||
| name: deleteDump | |||
| args: | |||
| image: ghcr.io/kanisterio/postgres-kanister-tools:0.84.0 | |||
| namespace: "{{ .Namespace.Name }}" | |||
| namespace: "{{ .StatefulSet.Namespace }}" | |||
There was a problem hiding this comment.
Same as above
Also, I believe this blueprint is no longer relevant. We can remove the v10.16.2 and v8.6.4 folders completely. @viveksinghggits @PrasadG193 WDYT?
There was a problem hiding this comment.
reverted the change
There was a problem hiding this comment.
sorry, maybe I am missing some context. Why this blueprint not relevant?
There was a problem hiding this comment.
@viveksinghggits are there any specific uses for this blueprint? Do we need to support this particular version of postgres?
There was a problem hiding this comment.
I don't think we have to support that specific version. But I think it's ok to keep the stale versions of blueprint just for future reference. if someone wants to refer to specific postgres' versions blueprint.
I think this is the reason we decided to have these dirs with older blueprints right?
I am also ok if decide to remove them.
shahpratikr
force-pushed
the
fix_postgresql_readme
branch
2 times, most recently
from
31cc082
to
75c81f6
Compare
shahpratikr
force-pushed
the
fix_postgresql_readme
branch
3 times, most recently
from
a82af0d
to
fac2bb4
Compare
- fixed kanctl installation link - updated responses for actionset
shahpratikr
force-pushed
the
fix_postgresql_readme
branch
from
fac2bb4
to
5bfd415
Compare
| FROM postgres:14-bullseye | ||
|
|
||
| LABEL maintainer="vkamra@kasten.io" | ||
| FROM postgres:15-bullseye |
There was a problem hiding this comment.
As a follow-up, we should remove this Dockerfile and stop building this image through goreleaser. I don't think we use this anymore
Change Overview
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan