Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed steps for MongoDB example #1780

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Fixed steps for MongoDB example #1780

merged 2 commits into from
Dec 12, 2022

Conversation

shahpratikr
Copy link
Contributor

@shahpratikr shahpratikr commented Dec 9, 2022

Change Overview

  • replaced mongo command is replaced by mongosh command due to change in latest mongodb chart
  • fixed namespace name in commands

Pull request type

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Dec 9, 2022
@viveksinghggits
Copy link
Contributor

@shahpratikr do we need changes in the blueprint as well? Also, it looks like you have put PR desc twice.

@shahpratikr
Copy link
Contributor Author

shahpratikr commented Dec 9, 2022

do we need changes in the blueprint as well?

No changes were needed in blueprint

- replaced mongo command is replaced by mongosh command due to change
in latest mongodb chart
- fixed namespace name in commands
Kanister automation moved this from In Progress to Reviewer approved Dec 10, 2022
@pavannd1 pavannd1 added the kueue label Dec 12, 2022
@mergify mergify bot merged commit 9238811 into master Dec 12, 2022
Kanister automation moved this from Reviewer approved to Done Dec 12, 2022
@mergify mergify bot deleted the fix_mongodb_example branch December 12, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants