Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "sed" command in other Postgres BPs #1797

Merged
merged 4 commits into from
Dec 16, 2022
Merged

Conversation

pavannd1
Copy link
Contributor

Change Overview

Missed changing this in #1796

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@pavannd1 pavannd1 changed the title Update sed command in deployment config BP Update "sed" command in Postgres deployment config BP Dec 16, 2022
@infraq infraq added this to In Progress in Kanister Dec 16, 2022
@pavannd1 pavannd1 added the kueue label Dec 16, 2022
@akankshakumari393
Copy link
Contributor

@pavannd1 I think we should modify this as well,

replaceCommand = " sed 's/LOCALE/LC_COLLATE/' |"
. Its not failing currently but would to be safe to have it.

@pavannd1 pavannd1 changed the title Update "sed" command in Postgres deployment config BP Update "sed" command in other Postgres BPs Dec 16, 2022
@akankshakumari393
Copy link
Contributor

Successfully Tested the RDS function changes using RDS dump blueprint on E2E -

./build/integration-test.sh ^RDSPostgreSQLDump$

https://gist.github.com/akankshakumari393/a6633102de6c10d24f3d962813cfcf6f

Copy link
Contributor

@akankshakumari393 akankshakumari393 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Dec 16, 2022
@mergify mergify bot merged commit 8663ebd into master Dec 16, 2022
Kanister automation moved this from Reviewer approved to Done Dec 16, 2022
@mergify mergify bot deleted the up-pg-depconfig-bp branch December 16, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants