Add a field in actionset status to figure out currently running phase #1798

viveksinghggits · 2022-12-16T14:58:17Z

Change Overview

This PR adds another field in the actionset status that can be used to figure out the currently running phase of the actionset set.
And also adds that field in the additionalPrinterColumns so that we can get the phase that is currently running in the kubectl output itself.

Every 2.0s: kubectl get actionsets.cr.kanister.io -n kanister                         vivek: Mon Dec 26 19:48:30 2022

NAME           PROGRESS   RUNNINGPHASE   LAST TRANSITION TIME   STATE
backup-mqw49   66.67                     2022-12-26T18:47:32Z   complete
backup-tcqb7   66.67                     2022-12-26T18:47:06Z   complete
backup-vqzq8   33.33                     2022-12-26T18:48:16Z   failed
backup-zxxwd   33.33                     2022-12-26T18:48:00Z   failed

Pull request type

Please check the type of change your PR introduces:

Issues

fixes #issue-number

Test Plan

💪 Manual
⚡ Unit test
💚 E2E

github-actions · 2022-12-16T14:59:35Z

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

pkg/controller/controller_test.go

ankitjain235

Added some questions/suggestions.

pkg/apis/cr/v1alpha1/types.go

pkg/phase.go

pkg/customresource/actionset.yaml

viveksinghggits · 2022-12-26T18:48:51Z

Every 2.0s: kubectl get actionsets.cr.kanister.io -n kanister                         vivek: Mon Dec 26 19:48:30 2022

NAME           PROGRESS   RUNNINGPHASE   LAST TRANSITION TIME   STATE
backup-mqw49   66.67                     2022-12-26T18:47:32Z   complete
backup-tcqb7   66.67                     2022-12-26T18:47:06Z   complete
backup-vqzq8   33.33                     2022-12-26T18:48:16Z   failed
backup-zxxwd   33.33                     2022-12-26T18:48:00Z   failed

This commit adds another field in the actionset status that can be used to figure out the currently running phase of the actionset set.

Add test to make sure the phases that are in blueprint are actually being set in the actionset status.progress correctly.

This commit changes the `onPhase` field to `runningPhase` and also makes sure that `status.Progress.RunningPhase` is updated with either complete of failed values, based on the actionset's status, to make sure things are not confusing.

PrasadG193

Have some minor suggestions. Otherwise looks good

pkg/controller/controller.go

pkg/controller/controller_test.go

pkg/customresource/actionset.yaml

PrasadG193

LGTM

docs/tutorial.rst

pkg/controller/controller.go

pkg/controller/controller_test.go

pkg/customresource/actionset.yaml

viveksinghggits · 2022-12-30T12:12:57Z

CI failed once because of

FAIL: <autogenerated>:1: PostgreSQL.TestRun

integration_test.go:220:
    c.Assert(err, IsNil)
... value *exec.ExitError = &exec.ExitError{ProcessState:(*os.ProcessState)(0xc000f722e8), Stderr:[]uint8(nil)} ("signal: killed")

It seems to be a resource issue. I have re-triggered the CI, if we see this again, we can talk to Github Actions team to know more about the machines where these tests run and what we can do about those.

This document also has details about the runners that are used to run these tests https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

infraq added this to In Progress in Kanister Dec 16, 2022

viveksinghggits requested review from ankitjain235, pavannd1 and PrasadG193 December 16, 2022 15:06

viveksinghggits force-pushed the actionsetstatus-onphase branch 3 times, most recently from a06132e to e35ea62 Compare December 19, 2022 15:43

viveksinghggits commented Dec 19, 2022

View reviewed changes

pkg/controller/controller_test.go Outdated Show resolved Hide resolved

ankitjain235 reviewed Dec 20, 2022

View reviewed changes

pkg/apis/cr/v1alpha1/types.go Outdated Show resolved Hide resolved

pkg/apis/cr/v1alpha1/types.go Outdated Show resolved Hide resolved

pkg/phase.go Outdated Show resolved Hide resolved

pkg/customresource/actionset.yaml Outdated Show resolved Hide resolved

viveksinghggits requested a review from ankitjain235 December 23, 2022 16:09

pavannd1 assigned PrasadG193 Dec 23, 2022

viveksinghggits added 5 commits December 29, 2022 11:02

Add a field in actionset status to figure out currently running phase

69e038e

This commit adds another field in the actionset status that can be used to figure out the currently running phase of the actionset set.

Fix compilation error by passing nil actionset

8fb3cc2

Add unit test for actionset.status.progress.onPhase

f1c2b09

Add test to make sure the phases that are in blueprint are actually being set in the actionset status.progress correctly.

Running phase should be "" after actionset is completed

fe88d25

viveksinghggits force-pushed the actionsetstatus-onphase branch from 13b9e5c to fe88d25 Compare December 29, 2022 10:02

PrasadG193 reviewed Dec 29, 2022

View reviewed changes

pkg/controller/controller.go Outdated Show resolved Hide resolved

pkg/controller/controller_test.go Outdated Show resolved Hide resolved

pkg/customresource/actionset.yaml Outdated Show resolved Hide resolved

Fix typo, correct error

9a6d58e

viveksinghggits requested a review from PrasadG193 December 29, 2022 12:54

PrasadG193 reviewed Dec 29, 2022

View reviewed changes

Kanister automation moved this from In Progress to Reviewer approved Dec 29, 2022

PrasadG193 approved these changes Dec 29, 2022

View reviewed changes

viveksinghggits added kueue hold off merging labels Dec 29, 2022

Update docs to reflect Status.Progress.RunningPhase change

f69ceea

akankshakumari393 reviewed Dec 29, 2022

View reviewed changes

docs/tutorial.rst Outdated Show resolved Hide resolved

Improve docs sentence

bddeacf

viveksinghggits requested review from akankshakumari393 and PrasadG193 December 29, 2022 15:16

pavannd1 reviewed Dec 30, 2022

View reviewed changes

pavannd1 removed the kueue label Dec 30, 2022

Address review comments, sentence/grammar improv

7829279

pavannd1 approved these changes Jan 3, 2023

View reviewed changes

viveksinghggits added kueue and removed hold off merging labels Jan 3, 2023

Merge branch 'master' into actionsetstatus-onphase

a81f9e8

mergify bot merged commit 59124c5 into master Jan 3, 2023

mergify bot deleted the actionsetstatus-onphase branch January 3, 2023 20:50

Kanister automation moved this from Reviewer approved to Done Jan 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a field in actionset status to figure out currently running phase #1798

Add a field in actionset status to figure out currently running phase #1798

viveksinghggits commented Dec 16, 2022 •

edited

Loading

github-actions bot commented Dec 16, 2022

ankitjain235 left a comment

viveksinghggits commented Dec 26, 2022

PrasadG193 left a comment

PrasadG193 left a comment

viveksinghggits commented Dec 30, 2022 •

edited

Loading

Add a field in actionset status to figure out currently running phase #1798

Add a field in actionset status to figure out currently running phase #1798

Conversation

viveksinghggits commented Dec 16, 2022 • edited Loading

Change Overview

Pull request type

Issues

Test Plan

github-actions bot commented Dec 16, 2022

ankitjain235 left a comment

Choose a reason for hiding this comment

viveksinghggits commented Dec 26, 2022

PrasadG193 left a comment

Choose a reason for hiding this comment

PrasadG193 left a comment

Choose a reason for hiding this comment

viveksinghggits commented Dec 30, 2022 • edited Loading

viveksinghggits commented Dec 16, 2022 •

edited

Loading

viveksinghggits commented Dec 30, 2022 •

edited

Loading