-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a field in actionset status to figure out currently running phase #1798
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
a06132e
to
e35ea62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some questions/suggestions.
|
This commit adds another field in the actionset status that can be used to figure out the currently running phase of the actionset set.
Add test to make sure the phases that are in blueprint are actually being set in the actionset status.progress correctly.
This commit changes the `onPhase` field to `runningPhase` and also makes sure that `status.Progress.RunningPhase` is updated with either complete of failed values, based on the actionset's status, to make sure things are not confusing.
13b9e5c
to
fe88d25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have some minor suggestions. Otherwise looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI failed once because of
It seems to be a resource issue. I have re-triggered the CI, if we see this again, we can talk to Github Actions team to know more about the machines where these tests run and what we can do about those. This document also has details about the runners that are used to run these tests https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources |
Change Overview
This PR adds another field in the actionset status that can be used to figure out the currently running phase of the actionset set.
And also adds that field in the
additionalPrinterColumns
so that we can get the phase that is currently running in the kubectl output itself.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan