Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI #1828

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Update CI #1828

merged 3 commits into from
Jan 5, 2023

Conversation

pavannd1
Copy link
Contributor

Change Overview

Fixes:

  1. GHA errors
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: docker/login-action@v1
  1. Reduce the parallelism of integration tests to 3

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Dec 30, 2022
akankshakumari393
akankshakumari393 approved these changes Dec 31, 2022
View reviewed changes
Copy link
Contributor

@akankshakumari393 akankshakumari393 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Just curious, any specific reason we are changing the DOP 🤔

Kanister automation moved this from In Progress to Reviewer approved Dec 31, 2022
@pavannd1
Copy link
Contributor Author

pavannd1 commented Jan 5, 2023

@akankshakumari393 Vivek had noticed CI running out of resources when running integration tests. Reducing DOP might help with that.

@pavannd1 pavannd1 merged commit 313c186 into master Jan 5, 2023
@pavannd1 pavannd1 deleted the update-gha-ci branch January 5, 2023 22:54
Kanister automation moved this from Reviewer approved to Done Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akankshakumari393 akankshakumari393 akankshakumari393 approved these changes

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

Assignees
No one assigned
Labels
None yet
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pavannd1 @akankshakumari393