-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed image values for MongoDB and PostgresDB charts in integration tests #1831
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
@shahpratikr could you please add the test plan? |
added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a comment, otherwise looks good.
b517f3d
to
2e554c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, we should create two different PRs when changes are done to different workflows/examples, etc. It makes reviewing easier and reverts too in case of issues in one workflow.
… tests - removed usage of kanister images while installing MongoDB and PostgresDB helm charts - fixed minor issues in formatting
2e554c2
to
742008b
Compare
Change Overview
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Ran integration tests for Mongodb and Postgresql using following commands
./build/integration-test.sh ^PostgreSQL$
and./build/integration-test.sh ^MongoDB$