-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not ignore permission errors in kopia restore command #1835
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like @pavannd1 or someone else from his team to approve to make sure that they are aware of it and potential implications it can bring.
Probably we should not hardcode it in kanister but propagate --ignore-permission-errors
flag value from k10 to avoid any issues for external kanister users.
The only doubts I have is about using strconv in commands. Maybe it would be better to create AppendLoggableKVBool function and convert from bool to string in that function and not in command? @pavannd1 @pchistikov |
d588f4b
to
2e76a4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can follow up with the improvement you suggested above 👍🏼
Change Overview
By default kopia ignores all the errors about permissions (see https://github.com/kopia/kopia/blob/master/cli/command_restore.go#L144)
It leads to hiding such errors and incorrectly restored apps without any notifications.
Pull request type
Please check the type of change your PR introduces:
Test Plan