-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Kanister function WaitV2 #1836
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I have a small question in the code but I think I auto answer it, otherwise thanks for asking me the review the unit test you wrote were very interesting, the documentation is also very good.
caa8d13
to
acfe7ce
Compare
Rebased and fixed conflicts. @pavannd1 could you please take a look? |
* Switch to go template syntax for Wait conditions Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> * Update K8ssandra BP as per the new Wait func syntax Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com> Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
96ccaed
to
a8431ee
Compare
Change Overview
This PR adds new function
WaitV2
improved version of existingWait
function which simplifies the condition definition.Instead of Jsonpath to fetch K8s object value, we can use go-template syntax which can be validated with kubectl.
e.g To check if the deployment is ready, once can form following go-template which can be validated with
kubectl
-The same go-template can be used in the
WaitV2
function arg to define conditionPull request type
Please check the type of change your PR introduces:
Issues
Test Plan
💪 Manual
⚡ Unit test
💚 E2E
Added unit tests
Manually validated the BP mentioned in the PR description on a deployment