Format bool arguments in a way it expected by kopia's cmd lib. #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
TimonOmsk
requested review from
pavannd1,
pchistikov,
ankitjain235 and
r4rajat
pchistikov
reviewed
Jan 9, 2023
adowair
approved these changes
Jan 9, 2023
pavannd1
reviewed
Jan 9, 2023
pkg/kopia/command/snapshot.go
Outdated
| @@ -64,7 +64,7 @@ type SnapshotRestoreCommandArgs struct { | |||
| func SnapshotRestore(cmdArgs SnapshotRestoreCommandArgs) []string { | |||
| args := commonArgs(cmdArgs.CommandArgs, false) | |||
| args = args.AppendLoggable(snapshotSubCommand, restoreSubCommand, cmdArgs.SnapID, cmdArgs.TargetPath) | |||
| args = args.AppendLoggableKV(ignorePermissionsError, strconv.FormatBool(cmdArgs.IgnorePermissionErrors)) | |||
| args = args.AppendLoggableBool(ignorePermissionsError, cmdArgs.IgnorePermissionErrors) | |||
There was a problem hiding this comment.
@TimonOmsk Wouldn't it be simpler if we do
if cmdArgs.IgnorePermissionErrors {
args = args.AppendLoggable(ignorePermissionsError)
} else {
args = args.AppendLoggable(noIgnorePermissionsError)
}
noIgnorePermissionsError is a constant with --no-ignore-permission-errors value
There was a problem hiding this comment.
It's simpler, but we'd have to introduce 2 arguments for every single argument. I think it's up to you here. If you think it's easier I would do it :)
There was a problem hiding this comment.
I like @pavannd1's proposal. It's simple and straightforward.
pchistikov
approved these changes
Jan 9, 2023
pavannd1
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Kopia uses Kingpin(https://github.com/alecthomas/kingpin) lib for handling cmd args.
This lib does not allow to set bool var in k=v way. Instead it uses k\no-k format.
It means that instead of --ingore-permission-errors=false we should use --no-ignore-permission-errors argument.
From https://github.com/alecthomas/kingpin/blob/master/README.md#boolean-values
Pull request type
Please check the type of change your PR introduces:
Test Plan