Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cyclic dependency and allow to pass Parallelism as an argument #1859

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Remove cyclic dependency and allow to pass Parallelism as an argument #1859

merged 3 commits into from
Jan 12, 2023

Conversation

r4rajat
Copy link
Contributor

@r4rajat r4rajat commented Jan 12, 2023 •
edited

Signed-off-by: Rajat Gupta rajat.gupta@veeam.com

Change Overview

  • Remove cyclic dependency from package kopia/cmd
  • Allow users to pass Parallelism in SnapshotCreateCommandArgs instead from Environmental Variables

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@r4rajat
Remove cyclic dependency from package kopia
5e12f80 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat r4rajat self-assigned this Jan 12, 2023
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Jan 12, 2023
@r4rajat r4rajat changed the title Remove cyclic dependency Remove cyclic dependency and allow to pass Paralleism as an argument Jan 12, 2023
Kanister automation moved this from In Progress to Reviewer approved Jan 12, 2023
@r4rajat r4rajat changed the title Remove cyclic dependency and allow to pass Paralleism as an argument Remove cyclic dependency and allow to pass Paralism as an argument Jan 12, 2023
@r4rajat r4rajat requested a review from pavannd1 January 12, 2023 09:06
@r4rajat r4rajat added the kueue label Jan 12, 2023
@PrasadG193 PrasadG193 removed the kueue label Jan 12, 2023
@r4rajat
Update Tests
abf70b3 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Change Export Variables to Non Export type
f66a2be 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat r4rajat changed the title Remove cyclic dependency and allow to pass Paralism as an argument Remove cyclic dependency and allow to pass Parallism as an argument Jan 12, 2023
@r4rajat r4rajat changed the title Remove cyclic dependency and allow to pass Parallism as an argument Remove cyclic dependency and allow to pass Parallelism as an argument Jan 12, 2023
@mergify mergify bot merged commit e65900e into master Jan 12, 2023
Kanister automation moved this from Reviewer approved to Done Jan 12, 2023
@mergify mergify bot deleted the remove-cyclic-dependency branch January 12, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@ankitjain235 ankitjain235 ankitjain235 approved these changes

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees

@r4rajat r4rajat

Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r4rajat @PrasadG193 @ankitjain235