Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change kopia command logs to info #1879

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Change kopia command logs to info #1879

merged 2 commits into from
Jan 25, 2023

Conversation

ankitjain235
Copy link
Contributor

@ankitjain235 ankitjain235 commented Jan 25, 2023

Change Overview

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Jan 25, 2023
Kanister automation moved this from In Progress to Reviewer approved Jan 25, 2023
@pavannd1 pavannd1 added kueue and removed kueue labels Jan 25, 2023
@pavannd1 pavannd1 merged commit 0ead112 into master Jan 25, 2023
Kanister automation moved this from Reviewer approved to Done Jan 25, 2023
@pavannd1 pavannd1 deleted the kopia-command-info branch January 25, 2023 12:58
@julio-lopez
Copy link
Contributor

@ankitjain235 @pavannd1
Folks,

What's the motivation for this change? there is nothing in the PR description, nor the commit(s)

What are the tradeoffs and implications of this change? for example in terms of verbosity and total log size.

@ankitjain235
Copy link
Contributor Author

@julio-lopez This was Info earlier as well. After we did refactoring, we made it to Debug but that was making it difficult to find which exact command failed in test as well as customer environments, so we needed to make it info again.
Sorry for the missing PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants