Add conversion from s3Compliant type to s3 type #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
Comment on lines
+187
to
+189
| if locType == LocType(v1alpha1.LocationTypeS3Compliant) { | ||
| m[typeKey] = []byte(LocTypeS3) | ||
| } |
There was a problem hiding this comment.
what is the value of locType in case of the if statement? is it not LocTypeS3 already?
LGTM
There was a problem hiding this comment.
For Kanister profiles, it's s3Compliant while we have s3 as value of LocTypeS3.
PrasadG193
reviewed
Feb 3, 2023
PrasadG193
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR adds conversion from s3Compliant type to s3. For cases with kanister profiles, the profile type is still "s3Compliant". Since for kopia, the s3Compliant type is same as s3, this PR adds the necessary conversion in the utility.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan