Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GOMODCACHE path in codegen script #1884

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Conversation

kale-amruta
Copy link
Contributor

Change Overview

With recent changes to build image, make codegen was failing with this error since the path GOMODCACHE= in the build container has changed

+ chmod +x /root/go/pkg/mod/k8s.io/code-generator@v0.24.4/generate-groups.sh
chmod: cannot access '/root/go/pkg/mod/k8s.io/code-generator@v0.24.4/generate-groups.sh': No such file or directory
make[1]: *** [Makefile:214: run] Error 1

This PR is to modify the path in the script according to build container

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Output of codegen after updating the script:

make[1]: Entering directory '/home/infracloud/go/src/github.com/kanisterio/kanister'
running CMD in the containerized build environment
+ export GO111MODULE=on
+ GO111MODULE=on
+ go mod download
++ go list -f '{{.Version}}' -m k8s.io/code-generator
+ execDir=/go/pkg/mod/k8s.io/code-generator@v0.24.4
+ chmod +x /go/pkg/mod/k8s.io/code-generator@v0.24.4/generate-groups.sh
+ /go/pkg/mod/k8s.io/code-generator@v0.24.4/generate-groups.sh all github.com/kanisterio/kanister/pkg/client github.com/kanisterio/kanister/pkg/apis cr:v1alpha1 --go-header-file /go/pkg/mod/k8s.io/code-generator@v0.24.4/hack/boilerplate.go.txt -o /go/src/
Generating deepcopy funcs
Generating clientset for cr:v1alpha1 at github.com/kanisterio/kanister/pkg/client/clientset
Generating listers for cr:v1alpha1 at github.com/kanisterio/kanister/pkg/client/listers
Generating informers for cr:v1alpha1 at github.com/kanisterio/kanister/pkg/client/informers
make[1]: Leaving directory '/home/infracloud/go/src/github.com/kanisterio/kanister'

@kale-amruta kale-amruta marked this pull request as ready for review February 2, 2023 10:59
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Feb 2, 2023
Copy link
Contributor

@akankshakumari393 akankshakumari393 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Feb 2, 2023
Copy link
Contributor

@r4rajat r4rajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PrasadG193
Copy link
Contributor

@kale-amruta could you please update the title of PR? Can be merged after that.

@kale-amruta kale-amruta changed the title update codegen script fix GOMODCACHE path in codegen script Feb 3, 2023
@mergify mergify bot merged commit a8ef704 into master Feb 3, 2023
Kanister automation moved this from Reviewer approved to Done Feb 3, 2023
@mergify mergify bot deleted the updateClientCodegenScript branch February 3, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants