Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README for Kafka example #1885

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Improve README for Kafka example #1885

merged 3 commits into from
Feb 10, 2023

Conversation

akankshakumari393
Copy link
Contributor

@akankshakumari393 akankshakumari393 commented Feb 3, 2023

Change Overview

This PR improves the example README for Kafka

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Feb 3, 2023
@akankshakumari393 akankshakumari393 changed the title Improve Readme Docs for Kafka Improve Readme for Kafka Feb 3, 2023
@akankshakumari393 akankshakumari393 changed the title Improve Readme for Kafka Improve README for Kafka Feb 3, 2023
@akankshakumari393 akankshakumari393 changed the title Improve README for Kafka Improve README for Kafka example Feb 3, 2023
examples/kafka/adobe-s3-connector/README.md Show resolved Hide resolved
examples/kafka/adobe-s3-connector/README.md Outdated Show resolved Hide resolved
examples/kafka/adobe-s3-connector/README.md Outdated Show resolved Hide resolved
examples/kafka/adobe-s3-connector/README.md Outdated Show resolved Hide resolved
Kanister automation moved this from In Progress to Reviewer approved Feb 9, 2023
@mergify mergify bot merged commit c084a0a into master Feb 10, 2023
Kanister automation moved this from Reviewer approved to Done Feb 10, 2023
@mergify mergify bot deleted the improve_kafka_docs branch February 10, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants