Add support for multiple containers in created pods #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
e-sumin
reviewed
Feb 6, 2023
denisvmedia
reviewed
Feb 7, 2023
pavannd1
requested review from
viveksinghggits
and removed request for
miquella
e-sumin
approved these changes
Feb 13, 2023
PrasadG193
approved these changes
Feb 17, 2023
|
@e-sumin, I've updated this branch due your last changes, could you take a look pls? |
e-sumin
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This pull request resolves an issue with obtaining logs when a sidecar is added using the podOverride feature.
I have ensured that the main container is always first in spec, and logs are taken from the first container in the pod.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan