Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update condition for statefulset ready in Wait tests #1889

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Update condition for statefulset ready in Wait tests #1889

merged 1 commit into from
Feb 7, 2023

Conversation

PrasadG193
Copy link
Contributor

Change Overview

This PR

  • Updates wait for ready conditions for statefulset in Wait func unit tests
  • Fixes UT failures on GKE 1.21 clusters

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Validated unit tests against gke cluster

$ go test -v -check.f="Wait*" .
=== RUN   Test
OK: 4 passed
--- PASS: Test (42.33s)
PASS
ok      github.com/kanisterio/kanister/pkg/function     43.352s

@PrasadG193
Update condition for sts ready in Wait tests
872c95a 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Feb 7, 2023
Kanister automation moved this from In Progress to Reviewer approved Feb 7, 2023
@PrasadG193 PrasadG193 changed the title Update condition for sts ready in Wait tests Update condition for statefulset ready in Wait tests Feb 7, 2023
@mergify mergify bot merged commit f658f6f into master Feb 7, 2023
Kanister automation moved this from Reviewer approved to Done Feb 7, 2023
@mergify mergify bot deleted the fix-wait-tests branch February 7, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@onkarbhat onkarbhat Awaiting requested review from onkarbhat

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PrasadG193 @viveksinghggits