Fixed issue-1176: Reduce resource requests while installing minio #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
shahpratikr
force-pushed
the
pratik/issue-1176
branch
from
36cae45
to
8e668fb
Compare
shahpratikr
force-pushed
the
pratik/issue-1176
branch
from
8e668fb
to
e32c860
Compare
PrasadG193
reviewed
Feb 9, 2023
|
In fact, for tests, we don't even need persistent minio storage. |
shahpratikr
force-pushed
the
pratik/issue-1176
branch
2 times, most recently
from
23a69ab
to
8ae0e60
Compare
viveksinghggits
approved these changes
Feb 10, 2023
PrasadG193
approved these changes
Feb 10, 2023
- Set resources.requests.memory to 2Gi Signed-off-by: Pratik Shah <pratik@infracloud.io>
shahpratikr
force-pushed
the
pratik/issue-1176
branch
from
8ae0e60
to
7b31c5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pratik Shah pratik@infracloud.io
Change Overview
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Ran integration tests locally
make install-minio; make integration-tests