Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in case when pod creation failed #1898

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

e-sumin
Copy link
Contributor

@e-sumin e-sumin commented Feb 10, 2023

Change Overview

There was a bug when POD creation failed. pod can't be used and namespace should be taken from opts.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Feb 10, 2023
@e-sumin e-sumin removed their assignment Feb 10, 2023
Kanister automation moved this from In Progress to Reviewer approved Feb 10, 2023
@pavannd1 pavannd1 added the kueue label Feb 14, 2023
@mergify mergify bot merged commit 8262fad into master Feb 14, 2023
Kanister automation moved this from Reviewer approved to Done Feb 14, 2023
@mergify mergify bot deleted the fix-panic-after-pod-creation-failed branch February 14, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants