Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing RestoreDataPodOverrideArg constant in restore_data function #1911

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

shahpratikr
Copy link
Contributor

Change Overview

Added missing RestoreDataPodOverrideArg constant in restore_data function

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Ran following commands to verify the change.

  • make check
  • make golint
  • make test
  • make build-controller
  • make release-controller IMAGE=docker.io/pratikrshah/controller VERSION=0.89.0
  • helm install kanister ./helm/kanister-operator --create-namespace --namespace kanister --set image.repository=docker.io/pratikrshah/controller --set image.tag=0.89.0
  • cd examples/mongodb-restic/
  • kubectl apply -f ./mongodb-blueprint.yaml

blueprint content for RestoreData function:

    # Restore data to primary db
    - func: RestoreData
      name: restorePrimary
      args:
        namespace: "{{ .StatefulSet.Namespace }}"
        image: ghcr.io/kanisterio/kanister-tools:0.89.0
        backupArtifactPrefix: "{{ .Profile.Location.Bucket }}/mongodb-backups/{{ .StatefulSet.Name }}/rs_backup"
        podOverride:
          containers:
          - name: container
            imagePullPolicy: IfNotPresent

Result:

blueprint.cr.kanister.io/mongodb-blueprint created

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Feb 16, 2023
@viveksinghggits
Copy link
Contributor

thank you @shahpratikr.

Kanister automation moved this from In Progress to Reviewer approved Feb 16, 2023
@mergify mergify bot merged commit cc44fa3 into master Feb 16, 2023
Kanister automation moved this from Reviewer approved to Done Feb 16, 2023
@mergify mergify bot deleted the pratik/issue-1909 branch February 16, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] Missing RestoreDataPodOverrideArg const in Arguments func in restore_data.go file.
2 participants