Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for ready #1915

Merged
merged 2 commits into from
Feb 18, 2023
Merged

Wait for ready #1915

merged 2 commits into from
Feb 18, 2023

Conversation

bathina2
Copy link
Contributor

Change Overview

This PR waits for the deployment and statefulset to be ready before running tests. This will fix the flaky behavior of the tests

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Feb 17, 2023
pavannd1
pavannd1 approved these changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Feb 18, 2023
@bathina2 bathina2 added the kueue label Feb 18, 2023
@mergify mergify bot merged commit 941c2af into master Feb 18, 2023
Kanister automation moved this from Reviewer approved to Done Feb 18, 2023
@mergify mergify bot deleted the kanister_tests_wait_fix branch February 18, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@ewhamilton ewhamilton Awaiting requested review from ewhamilton

@akankshakumari393 akankshakumari393 Awaiting requested review from akankshakumari393

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bathina2 @pavannd1