Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RepositoryServer ObjectReference in Actionset #1919

Merged
merged 31 commits into from
Mar 27, 2023
Merged

Add RepositoryServer ObjectReference in Actionset #1919

merged 31 commits into from
Mar 27, 2023

Conversation

r4rajat
Copy link
Contributor

@r4rajat r4rajat commented Feb 21, 2023 •
edited

Change Overview

Add RepositoryServer ObjectReference in kanctl command line to create various actions.
This PR adds support for passing --repository-server flag in kanctl command line

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Manual Testing Steps

Build kanctl command line tool

go build -o kanctl cmd/kanctl/main.go

Run Actionset

./kanctl create actionset --action backup --namespace kanister --blueprint backupdate-bp --deployment time-logger/time-logger --repository-server=kopia-repo-server-1

actionset backup-czvrz created

Also there's a check which ensures that Repository Server CR is in ServerReady state before creating actionset.

./kanctl create actionset --action backup --namespace kanister --blueprint backupdate-bp --deployment time-logger/time-logger --repository-server=kopia-repo-server-1

Please make sure that Repository Server CR 'kopia-repo-server-1' is in Ready State: Repository Server Not Ready
Error: resource verification failed

@r4rajat
Add RepositoryServer ObjectReference in crv1alpha1/types.go
bb9d131 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Feb 21, 2023
@r4rajat
Update custom resource file for Actionset
f6f6ace 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Add --repository-server flag in ActionSet
0c8edba 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Add --repository-server flag in ActionSet
924a241 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Add RepositoryServer in param.go in order to use with Blueprints
c127281 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Make sure Repository Server is in ServerReady state before creating A…
2ed6460 
…ctionSet

Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat r4rajat requested review from PrasadG193 and viveksinghggits and removed request for PrasadG193 February 21, 2023 06:10
@r4rajat r4rajat changed the title Add RepositoryServer ObjectReference in kanctl Add RepositoryServer ObjectReference in Actionset Feb 21, 2023
viveksinghggits
viveksinghggits reviewed Feb 22, 2023
View reviewed changes
pkg/customresource/actionset.yaml Show resolved Hide resolved
pkg/kanctl/actionset.go Outdated Show resolved Hide resolved
pkg/kanctl/actionset.go Outdated Show resolved Hide resolved
pkg/kanctl/actionset.go Outdated Show resolved Hide resolved
pkg/kanctl/actionset.go Outdated Show resolved Hide resolved
pkg/param/param.go Outdated Show resolved Hide resolved
r4rajat and others added 8 commits February 22, 2023 15:54
@r4rajat
Merge branch 'master' into repository-server-actionset
5e3bbb5
@r4rajat
Fixes
266e1f6 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Fixes
7debf4c 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Merge branch 'master' into repository-server-actionset
44cf91a
@r4rajat
Merge branch 'master' into repository-server-actionset
7ffc2ed
@r4rajat
Reduce cognitive complexity of function verifyParams
76c49c7 
- Earlier 38
- Now 26

Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Merge branch 'master' into repository-server-actionset
e4897e0
@r4rajat
Formatted Imports
c391105 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
viveksinghggits
viveksinghggits reviewed Mar 6, 2023
View reviewed changes
Copy link
Contributor

@viveksinghggits viveksinghggits left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost, there.

pkg/kanctl/actionset.go Outdated Show resolved Hide resolved
pkg/kanctl/actionset.go Show resolved Hide resolved
pkg/kanctl/actionset.go Outdated Show resolved Hide resolved
@r4rajat
Add Repository Server Address in Params
b9e58e0 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
r4rajat and others added 2 commits March 12, 2023 12:06
@r4rajat @viveksinghggits
Update pkg/kanctl/actionset.go
9499b47 
Co-authored-by: Vivek Singh <vsingh.ggits.2010@gmail.com>
@r4rajat
Update
eff7227 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat r4rajat mentioned this pull request Mar 13, 2023
Merged
10 tasks
@r4rajat
Address Review
4831b9b 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
r4rajat and others added 3 commits March 17, 2023 16:42
@r4rajat
Support to pass --repository-server flag in only --repository-server=…
3bc20e3 
…namespace/name

Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@r4rajat
Merge branch 'master' into repository-server-actionset
cecec9b
@r4rajat
Support to pass --repository-server flag in only --repository-server=…
0fbf7d8 
…namespace/name

Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
akankshakumari393
akankshakumari393 reviewed Mar 20, 2023
View reviewed changes
pkg/kanctl/actionset.go Show resolved Hide resolved
pkg/kanctl/actionset.go Outdated Show resolved Hide resolved
r4rajat and others added 3 commits March 20, 2023 12:09
@r4rajat @akankshakumari393
Update pkg/kanctl/actionset.go
8e0516c 
Co-authored-by: Akanksha kumari <akankshakumari393@gmail.com>
@r4rajat
Merge branch 'master' into repository-server-actionset
5c9730a
@r4rajat
fix spelling
1a92525 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
viveksinghggits
viveksinghggits requested changes Mar 20, 2023
View reviewed changes
pkg/param/param.go Outdated Show resolved Hide resolved
pkg/kanctl/actionset.go Show resolved Hide resolved
Kanister automation moved this from In Progress to Review Required Mar 20, 2023
@r4rajat
Add Warning if data mover flags are not provided.
8548a4c 
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
viveksinghggits
viveksinghggits reviewed Mar 21, 2023
View reviewed changes
pkg/kanctl/actionset.go Outdated Show resolved Hide resolved
pkg/kanctl/actionset.go Outdated Show resolved Hide resolved
pkg/param/param.go Outdated Show resolved Hide resolved
viveksinghggits
viveksinghggits approved these changes Mar 21, 2023
View reviewed changes
pkg/param/param.go Outdated Show resolved Hide resolved
Kanister automation moved this from Review Required to Reviewer approved Mar 21, 2023
@r4rajat r4rajat added the kueue label Mar 27, 2023
@mergify mergify bot merged commit e42eac0 into master Mar 27, 2023
Kanister automation moved this from Reviewer approved to Done Mar 27, 2023
@mergify mergify bot deleted the repository-server-actionset branch March 27, 2023 09:48
@r4rajat r4rajat mentioned this pull request Jun 19, 2023
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

@pavannd1 pavannd1 Awaiting requested review from pavannd1

@ankitjain235 ankitjain235 Awaiting requested review from ankitjain235

@kale-amruta kale-amruta Awaiting requested review from kale-amruta

@akankshakumari393 akankshakumari393 Awaiting requested review from akankshakumari393

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r4rajat @viveksinghggits @akankshakumari393