Configuration File .golangci.yml for golangci-lint Runs

[Bhargav-InfraCloud]

Change Overview

Configuration file .golangci.yml for golangci-lint runs as explained in #1761.

Changes

1. Linter: Run 7 default linters (errcheck, gosimple, govet, ineffassign, staticcheck, typecheck & unused) from .golangci.yaml.
2. Linter: Run linter gofmt from .golangci.yaml.
3. Linter: Run custom linters (maligned, whitespace, gocognit & unparam) from .golangci.yaml.
4. Linter: Remove linter maligned due to following reasons:
   • Linter maligned is archived by owner and deprecated from golangci-lint.
   • maligned (or it's replacement: govet's fieldalignment) recommends >50 struct's field alignment. Too many changes for much less value.
   • Struct fields might be ordered per their similarities. Rearranging for saving few bytes is not reasonable.

Pull request type

Please check the type of change your PR introduces:

• 🚧 Work in Progress
• 🌈 Refactoring (no functional changes, no api changes)
• 🐹 Trivial/Minor
• 🐛 Bugfix
• 🌻 Feature
• 🗺️ Documentation
• 🤖 Test

Issues

• fixes [Linter] Configure .golangci.yml in place of golint.sh and add additional linters #1761

Test Plan

• 💪 Manual
• ⚡ Unit test
• 💚 E2E

Run the command:

make golint

It should pass as it was before. Output similar to:

make[1]: Entering directory '/home/bhargav-infracloud/Workspace/go/src/github.com/Bhargav-InfraCloud/kanister'
running CMD in the containerized build environment
Running golangci-lint from config file: .golangci.yml
PASS

PASS

make[1]: Leaving directory '/home/bhargav-infracloud/Workspace/go/src/github.com/Bhargav-InfraCloud/kanister'

To Maintainers

The gofmt and govet are ran in make golint as well as the following scripts:
1. build/test.sh
2. examples/aws-rds/postgresql/pgtest/build/test.sh

Is there any particular reason for this or can these be eliminated from (or) replaced in scripts? This is discussed in the comments.

[PrasadG193]

We might want to address this. Can be addressed separately

[PrasadG193]

LGTM

[PrasadG193]

Is there any particular reason for this or can these be eliminated from (or) replaced in scripts?

@Bhargav-InfraCloud examples/aws-rds/postgresql/pgtest/ is a sample app that users can clone and try. Considering it as a separate project, we have kept its build scripts in its directory.

[Bhargav-InfraCloud]

@Bhargav-InfraCloud examples/aws-rds/postgresql/pgtest/ is a sample app that users can clone and try. Considering it as a separate project, we have kept its build scripts in its directory.

Makes sense. Thanks for letting me know and the approval.

[PrasadG193]

@Bhargav-InfraCloud could you please add attach the output of make golint and update the test plan?

[Bhargav-InfraCloud]

could you please add attach the output of make golint and update the test plan?

@PrasadG193 My bad I missed it. I've updated the desc now and rebased the code with the latest on master. Please check.

[Bhargav-InfraCloud]

Thanks @PrasadG193 😊