Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RDS postgres app implementation to execute postgres Query from pod #1946

Merged
merged 15 commits into from
Mar 16, 2023
Merged

Update RDS postgres app implementation to execute postgres Query from pod #1946

merged 15 commits into from
Mar 16, 2023

Conversation

akankshakumari393
Copy link
Contributor

Change Overview

Currently, we had assumed that the RDS Postgres instance would be accessible publicly, and we utilized Postgres drivers to execute queries in the database. However, this approach would not have been viable if we were dealing with private instances. In order to address this issue, this PR alters the implementation of the RDS application, allowing for queries to be executed using psql from a deployment resource instead.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Mar 9, 2023
@akankshakumari393 akankshakumari393 changed the title Update RDS postgres app implementation to execute postgres command from pod Update RDS postgres app implementation to execute postgres Query from pod Mar 9, 2023
@akankshakumari393 akankshakumari393 marked this pull request as ready for review March 9, 2023 04:32
viveksinghggits
viveksinghggits reviewed Mar 9, 2023
View reviewed changes
pkg/app/rds_postgres.go Outdated Show resolved Hide resolved
pkg/app/rds_postgres.go Outdated Show resolved Hide resolved
@akankshakumari393
Update RDS postgres app implementation, execute postgres command from…
1a696a7 
… Deployment

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Fix Lint Remove unnecessary trailing new line
b6619d8 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Initialize testWorkloadName field
8b3803c 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Move BastionWorkload function to be used as utility
7f8b439
@akankshakumari393
Minor refactor
1eefdd5 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Remove export of BastionWorkload() utility function
8c0f1fb 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
PrasadG193
PrasadG193 reviewed Mar 10, 2023
View reviewed changes
pkg/app/utils.go Outdated Show resolved Hide resolved
pkg/app/rds_postgres.go Outdated Show resolved Hide resolved
pkg/app/rds_postgres.go Outdated Show resolved Hide resolved
pkg/app/rds_postgres.go Outdated Show resolved Hide resolved
pkg/app/rds_postgres.go Outdated Show resolved Hide resolved
pkg/app/rds_postgres.go Outdated Show resolved Hide resolved
pkg/app/rds_postgres.go Outdated Show resolved Hide resolved
pkg/app/rds_postgres.go Outdated Show resolved Hide resolved
pkg/app/rds_postgres.go Outdated Show resolved Hide resolved
pkg/app/utils.go Outdated Show resolved Hide resolved
@akankshakumari393
Add app name in error messages
e2c9809 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Minor refactor
f11cb7f 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
PrasadG193
PrasadG193 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

pkg/app/utils.go Show resolved Hide resolved
Kanister automation moved this from In Progress to Reviewer approved Mar 10, 2023
@akankshakumari393
Minor refactor
0f87952 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
viveksinghggits
viveksinghggits reviewed Mar 10, 2023
View reviewed changes
Copy link
Contributor

@viveksinghggits viveksinghggits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/app/rds_postgres.go Outdated Show resolved Hide resolved
pkg/app/rds_postgres.go Outdated Show resolved Hide resolved
@akankshakumari393
Minor refactor
a293e9c 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Minor refactor
588f0b7 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
viveksinghggits
viveksinghggits approved these changes Mar 13, 2023
View reviewed changes
pkg/app/rds_postgres.go Outdated Show resolved Hide resolved
pkg/app/rds_postgres.go Outdated Show resolved Hide resolved
@akankshakumari393
Correct error message
59665c5
@akankshakumari393
Correct error message
0870884 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Use tail -f for test pod
833b899 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@mergify mergify bot merged commit cac55c9 into master Mar 16, 2023
Kanister automation moved this from Reviewer approved to Done Mar 16, 2023
@mergify mergify bot deleted the use_pod_rds_postgres branch March 16, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 Awaiting requested review from pavannd1

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akankshakumari393 @PrasadG193 @viveksinghggits