Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provision to create and delete DBSubnetGroups for RDS integration test #1950

Merged
merged 41 commits into from
Mar 17, 2023
Merged

Add provision to create and delete DBSubnetGroups for RDS integration test #1950

merged 41 commits into from
Mar 17, 2023

Conversation

akankshakumari393
Copy link
Contributor

Change Overview

This PR modifies RDS Postgres and Aurora apps to create and delete DBSubnet group. Also adds some utility functions related to that.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@akankshakumari393
Update RDS postgres app implementation, execute postgres command from…
1a696a7 
… Deployment

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Fix Lint Remove unnecessary trailing new line
b6619d8 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Initialize testWorkloadName field
8b3803c 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Move BastionWorkload function to be used as utility
7f8b439
@akankshakumari393
Minor refactor
1eefdd5 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Remove export of BastionWorkload() utility function
8c0f1fb 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Add app name in error messages
e2c9809 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Minor refactor
f11cb7f 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Minor refactor
0f87952 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Update RDS Aurora app implementation, execute mysql query from Deploy…
4e6a7b6 
…ment

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Remove unused methods from rds aurora app
da665de 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Minor refactor
3952de1 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Add helper methods to add DBSubnetGroup
a6514c0 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
add callers to create and delete dbsubnetGroups in rds postgres app test
4442497 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
add callers to create and delete dbsubnetGroups in rds aurora app test
3691915 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Refactor code
9748a04
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Mar 10, 2023
@akankshakumari393
Refactor code
6745c9f 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
remove duplicate import
ee35531 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
minor refactor
7d5078a
@akankshakumari393
Merge branch 'use_pod_rds_aurora' into aws_rds_secure
3387d47
@akankshakumari393
correct indentation
c209ab6
@akankshakumari393
Fix error
c346707
@akankshakumari393
Minor refactor
a293e9c 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Minor refactor
588f0b7 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Update RDS Aurora app implementation, execute mysql query from Deploy…
587d079 
…ment

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
PrasadG193
PrasadG193 reviewed Mar 17, 2023
View reviewed changes
pkg/app/utils.go Outdated Show resolved Hide resolved
pkg/app/rds_aurora_mysql.go Outdated Show resolved Hide resolved
pkg/app/rds_aurora_mysql.go
if err, ok := err.(awserr.Error); ok {
switch err.Code() {
case awsrds.ErrCodeDBSubnetGroupNotFoundFault:
log.Info().Print("Subnet Group Does not exist: ErrCodeDBSubnetGroupNotFoundFault.", field.M{"app": a.name, "name": a.dbSubnetGroup})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing return?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, because we don't want to return in case its not found.

pkg/app/rds_postgres.go Outdated Show resolved Hide resolved
pkg/app/utils.go Outdated Show resolved Hide resolved
Base automatically changed from use_pod_rds_aurora to master March 17, 2023 05:06
@akankshakumari393
Refactor code
a428244 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
viveksinghggits
viveksinghggits requested changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@viveksinghggits viveksinghggits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/app/utils.go Outdated Show resolved Hide resolved
pkg/app/utils.go Outdated Show resolved Hide resolved
Kanister automation moved this from In Progress to Review Required Mar 17, 2023
@akankshakumari393
Minor refactor
1104a7a 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Minor refactor
9bbaef5 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
viveksinghggits
viveksinghggits approved these changes Mar 17, 2023
View reviewed changes
pkg/app/utils.go Outdated Show resolved Hide resolved
Kanister automation moved this from Review Required to Reviewer approved Mar 17, 2023
@akankshakumari393
improve comments
4f66e47 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@mergify mergify bot merged commit d23ccdf into master Mar 17, 2023
Kanister automation moved this from Reviewer approved to Done Mar 17, 2023
@mergify mergify bot deleted the aws_rds_secure branch March 17, 2023 12:34
akankshakumari393 added a commit that referenced this pull request Mar 21, 2023
@akankshakumari393
Revert "Add provision to create and delete DBSubnetGroups for RDS int…
6c1ff74 
…egration test (#1950)"

This reverts commit d23ccdf.
@akankshakumari393 akankshakumari393 mentioned this pull request Mar 21, 2023
Merged
mergify bot pushed a commit that referenced this pull request Mar 21, 2023
@akankshakumari393
Revert "Add provision to create and delete DBSubnetGroups for RDS int…
f94584f 
…egration test (#1950)" (#1966)

This reverts commit d23ccdf.
akankshakumari393 added a commit that referenced this pull request Mar 28, 2023
@akankshakumari393
Revert "Revert "Add provision to create and delete DBSubnetGroups for…
9f0f83f 
… RDS integration test (#1950)" (#1966)"

This reverts commit f94584f.
mergify bot added a commit that referenced this pull request Mar 28, 2023
@akankshakumari393 @mergify
Revert "Revert "Add provision to create and delete DBSubnetGroups for…
e3f6654 
… RDS integration test (#1950)" (#1966)" (#1977)

This reverts commit f94584f.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@pavannd1 pavannd1 Awaiting requested review from pavannd1

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akankshakumari393 @PrasadG193 @viveksinghggits