Skip to content

Navigation Menu

Explore
By size
By industry
By use case
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

kanisterio / kanister Public

Notifications You must be signed in to change notification settings
Fork 152
Star 743

Code
Issues 66
Pull requests 29
Discussions
Actions
Projects 1
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `dbSubnetGroup` as outputArtifact to `CreateRDSSnapshot` function #1952

Merged

mergify merged 42 commits into master from modify_create_rds_snap

Mar 28, 2023

Merged

Add `dbSubnetGroup` as outputArtifact to `CreateRDSSnapshot` function #1952

mergify merged 42 commits into master from modify_create_rds_snap

Mar 28, 2023

Conversation 9 Commits 42 Checks 0 Files changed

Conversation

Copy link

Contributor

akankshakumari393 commented Mar 13, 2023

Change Overview

This PR add dbSubnetGroup as outputArtifact to CreateRDSSnapshot function

Pull request type

Please check the type of change your PR introduces:

🚧 Work in Progress
🌈 Refactoring (no functional changes, no api changes)
🐹 Trivial/Minor
🐛 Bugfix
🌻 Feature
🗺️ Documentation
🤖 Test

Issues

fixes #issue-number

Test Plan

💪 Manual
⚡ Unit test
💚 E2E

Sorry, something went wrong.

All reactions

akankshakumari393 added 30 commits

March 10, 2023 09:58


          Update RDS postgres app implementation, execute postgres command from…

1a696a7

… Deployment

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Fix Lint Remove unnecessary trailing new line

b6619d8

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Initialize testWorkloadName field

8b3803c

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Move BastionWorkload function to be used as utility

7f8b439


          Minor refactor

1eefdd5

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Remove export of BastionWorkload() utility function

8c0f1fb

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Add app name in error messages

e2c9809

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Minor refactor

f11cb7f

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Minor refactor

0f87952

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Update RDS Aurora app implementation, execute mysql query from Deploy…

4e6a7b6

…ment

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Remove unused methods from rds aurora app

da665de

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Minor refactor

3952de1

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Add helper methods to add DBSubnetGroup

a6514c0

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          add callers to create and delete dbsubnetGroups in rds postgres app test

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          add callers to create and delete dbsubnetGroups in rds aurora app test

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Refactor code

9748a04


          Refactor code

6745c9f

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          remove duplicate import

ee35531

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          minor refactor

7d5078a


          Merge branch 'use_pod_rds_aurora' into aws_rds_secure

3387d47


          correct indentation

c209ab6


          Fix error

c346707


          Minor refactor

a293e9c

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Minor refactor

588f0b7

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Update RDS Aurora app implementation, execute mysql query from Deploy…

587d079

…ment

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Remove unused methods from rds aurora app

a455ec7

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Minor refactor

c4bd0c2

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          minor refactor

df66bb4


          Minor refactor

523230e


          Merge branch 'use_pod_rds_aurora' into aws_rds_secure

4b32010

infraq added this to In Progress in Kanister

akankshakumari393 requested review from PrasadG193, viveksinghggits and pavannd1

March 13, 2023 10:26

viveksinghggits approved these changes

View reviewed changes

pkg/function/utils.go Outdated Show resolved Hide resolved

pkg/function/utils.go Outdated Show resolved Hide resolved

Kanister automation moved this from In Progress to Reviewer approved

PrasadG193 reviewed

View reviewed changes

pkg/function/create_rds_snapshot.go Outdated Show resolved Hide resolved

pkg/function/utils.go Show resolved Hide resolved

pkg/function/utils.go Show resolved Hide resolved


          Pass VpcId while creating security group

akankshakumari393 force-pushed the modify_create_rds_snap branch from 4b10821 to f7ee189 Compare

March 15, 2023 08:54


          Use securityGroup ID instead of security group name to authorizeSecur…

…ityGroupIngress

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>

akankshakumari393 force-pushed the modify_create_rds_snap branch from f7ee189 to ea422dd Compare

March 15, 2023 09:33


          Minor Fix

77ee4d2

akankshakumari393 force-pushed the modify_create_rds_snap branch from ea422dd to b3d7cf2 Compare

March 15, 2023 10:17

akankshakumari393 added 4 commits

March 16, 2023 12:30


          [Refactor] Add function to get VPCId for RDS apps

bca58e3

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Remove unnecessary comment

2fbfcec


          Modify Create RDS Snapshot function to add dbSubnetGroup as outputArt…

fcdf4b6

…ifact


          Refactor code

2c0863c

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>

akankshakumari393 force-pushed the modify_create_rds_snap branch from 5c3218e to 2c0863c Compare

March 16, 2023 07:55


          Use switch case

178a2d4

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>

PrasadG193 reviewed

View reviewed changes

pkg/function/create_rds_snapshot.go Outdated Show resolved Hide resolved

Base automatically changed from aws_rds_secure to master

March 17, 2023 12:34

akankshakumari393 added 2 commits

March 20, 2023 14:23


          Merge branch 'master' into modify_create_rds_snap

71d276a


          Refactor switch case

7243a53

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>

akankshakumari393 requested a review from PrasadG193

March 20, 2023 09:02

akankshakumari393 added 2 commits

March 20, 2023 18:37


          Remove unnecessary comment

091dd30

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>


          Merge branch 'master' into modify_create_rds_snap

66c2029

akankshakumari393 added the kueue label

mergify bot merged commit 45ccc4a into master

Kanister automation moved this from Reviewer approved to Done

mergify bot deleted the modify_create_rds_snap branch

March 28, 2023 15:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

viveksinghggits viveksinghggits approved these changes

pavannd1 Awaiting requested review from pavannd1

PrasadG193 Awaiting requested review from PrasadG193

Assignees

No one assigned

Labels

Projects

Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

None yet

3 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.