Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to enable/disable public access for RDS instances created during Test #1957

Merged
merged 51 commits into from
Mar 29, 2023
Merged

Add flag to enable/disable public access for RDS instances created during Test #1957

merged 51 commits into from
Mar 29, 2023

Conversation

akankshakumari393
Copy link
Contributor

@akankshakumari393 akankshakumari393 commented Mar 14, 2023 •
edited

Change Overview

This PR adds flag to enable/disable public access for RDS instances created during Test. It is for both RDS postgres and aurora instances. By default it would be set to false.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@akankshakumari393
Update RDS postgres app implementation, execute postgres command from…
1a696a7 
… Deployment

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Fix Lint Remove unnecessary trailing new line
b6619d8 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Initialize testWorkloadName field
8b3803c 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Move BastionWorkload function to be used as utility
7f8b439
@akankshakumari393
Minor refactor
1eefdd5 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Remove export of BastionWorkload() utility function
8c0f1fb 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Add app name in error messages
e2c9809 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Minor refactor
f11cb7f 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Minor refactor
0f87952 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Update RDS Aurora app implementation, execute mysql query from Deploy…
4e6a7b6 
…ment

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Remove unused methods from rds aurora app
da665de 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Minor refactor
3952de1 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Add helper methods to add DBSubnetGroup
a6514c0 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
add callers to create and delete dbsubnetGroups in rds postgres app test
4442497 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
add callers to create and delete dbsubnetGroups in rds aurora app test
3691915 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Refactor code
9748a04
@akankshakumari393
Refactor code
6745c9f 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
remove duplicate import
ee35531 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
minor refactor
7d5078a
@akankshakumari393
Merge branch 'use_pod_rds_aurora' into aws_rds_secure
3387d47
@akankshakumari393
correct indentation
c209ab6
@akankshakumari393
Fix error
c346707
@akankshakumari393
Minor refactor
a293e9c 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Minor refactor
588f0b7 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Update RDS Aurora app implementation, execute mysql query from Deploy…
587d079 
…ment

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Remove unused methods from rds aurora app
a455ec7 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Minor refactor
c4bd0c2 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
minor refactor
df66bb4
@akankshakumari393
Minor refactor
523230e
@akankshakumari393
Merge branch 'use_pod_rds_aurora' into aws_rds_secure
4b32010
@akankshakumari393
Modify RestoreRDSSnapshot and ExportRDSLocation function to accept db…
6c9f27b 
…SubnetGroup as optional argument

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
viveksinghggits
viveksinghggits reviewed Mar 17, 2023
View reviewed changes
pkg/app/rds_aurora_mysql.go Outdated Show resolved Hide resolved
pkg/aws/rds/rds.go Outdated Show resolved Hide resolved
@akankshakumari393
Set Public Access to false by default
956aea6 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
PrasadG193
PrasadG193 reviewed Mar 28, 2023
View reviewed changes
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll wait for Vivek's approval since he had few questions

viveksinghggits
viveksinghggits requested changes Mar 28, 2023
View reviewed changes
pkg/aws/rds/rds.go Outdated Show resolved Hide resolved
Kanister automation moved this from In Progress to Review Required Mar 28, 2023
Base automatically changed from modify_restore_rds_snap to master March 29, 2023 06:27
viveksinghggits
viveksinghggits reviewed Mar 29, 2023
View reviewed changes
pkg/aws/rds/rds.go Outdated Show resolved Hide resolved
Kanister automation moved this from Review Required to Reviewer approved Mar 29, 2023
@mergify mergify bot merged commit 7cde857 into master Mar 29, 2023
Kanister automation moved this from Reviewer approved to Done Mar 29, 2023
@mergify mergify bot deleted the rds_public_access branch March 29, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 left review comments

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akankshakumari393 @PrasadG193 @viveksinghggits