[Minor] Modify Create DB instance in RDS test to use DBsubnetGroup #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Deployment Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
…ment Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
…ment Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
…SubnetGroup as optional argument Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
…SubnetGroup as optional argument Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
akankshakumari393
changed the title
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
akankshakumari393
requested review from
viveksinghggits,
PrasadG193 and
pavannd1
PrasadG193
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR modifies the creation of DBInstance in RDS Test to use DBSubnetGroup. This is required in case VPC associated with securityGroup is not default.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan