Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated etcd example to mention tar availability in pod #1961

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

shahpratikr
Copy link
Contributor

Change Overview

This PR adds a note to mention tar package is required to run the etcd example.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Mar 17, 2023
Copy link
Contributor

@viveksinghggits viveksinghggits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/etcd/etcd-in-cluster/k8s/README.md Outdated Show resolved Hide resolved
Kanister automation moved this from In Progress to Review Required Apr 26, 2023
Kanister automation moved this from Review Required to Reviewer approved Apr 26, 2023
@mergify mergify bot merged commit 555b621 into master Apr 26, 2023
Kanister automation moved this from Reviewer approved to Done Apr 26, 2023
@mergify mergify bot deleted the pratik/issue-1839 branch April 26, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

etcd-incluster-blueprint.yaml Requires tar
2 participants