Parse kopia errors #1973
Merged
Parse kopia errors #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
e-sumin
force-pushed
the
kopia_errors_parsing
branch
2 times, most recently
from
294e90e
to
4efd20f
Compare
e-sumin
force-pushed
the
kopia_errors_parsing
branch
from
4efd20f
to
86d98fc
Compare
ankitjain235
reviewed
Apr 6, 2023
| var kopiaErrorPattern = regexp.MustCompile(`ERROR\s+(.*)`) | ||
|
|
||
| // ErrorFromOutput parses the output of a kopia and returns an error, if found | ||
| func ErrorsFromOutput(output string) []error { |
There was a problem hiding this comment.
Is this function only for kopia repository sub commands and not for other commands?
For example for kopia snapshot restore commands, it could be of format:
error restoring: restore error: error copying: copy file: error creating file:
Another example could be:
error setting attributes: could not change owner/group
There was a problem hiding this comment.
Thanks, I added couple more cases. I went through Kopia's repo and found that they have several unstructured error logs, but they will be covered by generic "last x log lines" mechanism.
|
@ankitjain235 @pavannd1 do you think it's mergeable now ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR introduces generic mechanism to parse Kopia errors.
Pull request type
Please check the type of change your PR introduces:
Test Plan