Rearrange order of snapshot APIs

[shahpratikr]

Change Overview

This PR rearranges the order of Snapshot APIs in v1 (stable), v1beta1 and v1alpha1.
This fixes taking snapshot when RKE2 snapshot-validation-hook is enabled.

Pull request type

Please check the type of change your PR introduces:

• 🚧 Work in Progress
• 🌈 Refactoring (no functional changes, no api changes)
• 🐹 Trivial/Minor
• 🐛 Bugfix
• 🌻 Feature
• 🗺️ Documentation
• 🤖 Test

Issues

Test Plan

• 💪 Manual

• ⚡ Unit test

• 💚 E2E

• Manually applied this fix in a cluster and was able to take a snapshot of a namespace when RKE2 webhook was enabled.

• All E2E tests passed.

• Manually verified backup taken before upgrade is getting restored after upgrade as well

Steps:

• Deployed cluster with k8s v1.22. (without these changes)
• Took a snapshot of a volume (attached volume snapshot details below)
• Upgraded cluster with these changes
• Restored snapshot

Volume snapshot details:

# kubectl describe volumesnapshot csi-snap-ckt7sqft6ld8jttg
Name:         csi-snap-ckt7sqft6ld8jttg
Namespace:    default
Annotations:  <none>
API Version:  snapshot.storage.k8s.io/v1
Kind:         VolumeSnapshot
Metadata:
  Creation Timestamp:  2023-03-31T06:57:46Z
  Finalizers:
    snapshot.storage.kubernetes.io/volumesnapshot-as-source-protection
    snapshot.storage.kubernetes.io/volumesnapshot-bound-protection
  Generation:  1
  Managed Fields:
    API Version:  snapshot.storage.k8s.io/v1beta1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
          f:name:
      f:spec:
        .:
        f:source:
          .:
          f:persistentVolumeClaimName:
        f:volumeSnapshotClassName:
    Manager:      executor-server
    Operation:    Update
    Time:         2023-03-31T06:57:46Z
    API Version:  snapshot.storage.k8s.io/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:finalizers:
          v:"snapshot.storage.kubernetes.io/volumesnapshot-bound-protection":
      f:status:
        .:
        f:boundVolumeSnapshotContentName:
    Manager:      snapshot-controller
    Operation:    Update
    Time:         2023-03-31T06:57:47Z
    API Version:  snapshot.storage.k8s.io/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:status:
        f:creationTime:
        f:readyToUse:
        f:restoreSize:
    Manager:         snapshot-controller
    Operation:       Update
    Subresource:     status
    Time:            2023-03-31T06:58:12Z
  Resource Version:  387948
  UID:               8bbeb46b-6609-4b19-9a82-642e663f0afb
Spec:
  Source:
    Persistent Volume Claim Name:  pv-claim
  Volume Snapshot Class Name:      pd-csi-snapshotclass
Status:
  Bound Volume Snapshot Content Name:  snapcontent-8bbeb46b-6609-4b19-9a82-642e663f0afb
  Creation Time:                       2023-03-31T06:57:49Z
  Ready To Use:                        true
  Restore Size:                        1Gi
Events:
  Type    Reason            Age   From                 Message
  ----    ------            ----  ----                 -------
  Normal  CreatingSnapshot  81s   snapshot-controller  Waiting for a snapshot default/csi-snap-ckt7sqft6ld8jttg to be created by the CSI driver.

[github-actions]

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

[pavannd1]

Since v1 is the default version in the newer clusters, this change makes sense 👍🏼

[PrasadG193]

Need to perform upgrade testing. E,g If Snapshot taken from older workflow can be restored by newer workflow. Please add detailed test plans in the PR discription. Thanks

[viveksinghggits]

@PrasadG193 we should also make sure that the snapshot related api version is different between these two tests/workflows right?

[PrasadG193]

Yes, we need to test for backward compatibility. If snapshots taken with beta APIs can be restored with stable API

[shahpratikr]

@PrasadG193 we have tried following things to verify the change.

• create an older k8s cluster (v1.19.16) on minikube, enabled csi-driver and volumesnapshot addons in it. I see that both v1 and v1beta1 snapshot API versions are available in the cluster.
• when volumesnapshot is created with v1beta1 version, conversion webhook converts it to v1 version while getting volumesnapshot using kubectl get volumesnapshot.
• we also tried to use older volumesnapshotter version (v4.0.0->minikube default version, v2.1.2->manually tried this), but observed same behavior with them as well