Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OCP 4.12 in templates #1984

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Support OCP 4.12 in templates #1984

merged 2 commits into from
Apr 12, 2023

Conversation

alexvbg
Copy link
Contributor

@alexvbg alexvbg commented Apr 3, 2023 •
edited

Change Overview

Add templates for ocp apps for 4.12 version. Similar to this PR
#1681

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@alexvbg alexvbg requested a review from pavannd1 April 3, 2023 13:22
@infraq infraq added this to In Progress in Kanister Apr 3, 2023
pavannd1
pavannd1 approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Apr 5, 2023
@alexvbg alexvbg added the kueue label Apr 12, 2023
@mergify mergify bot merged commit cccdbee into master Apr 12, 2023
Kanister automation moved this from Reviewer approved to Done Apr 12, 2023
@mergify mergify bot deleted the keu/asamarin/ocp-4-12-updates branch April 12, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexvbg @pavannd1