Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade openshift/api to release-4.15 branch #1988

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

julio-lopez
Copy link
Contributor

@julio-lopez julio-lopez commented Apr 5, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@julio-lopez
Copy link
Contributor Author

#1987

@julio-lopez julio-lopez marked this pull request as ready for review April 5, 2023 23:48
@julio-lopez julio-lopez marked this pull request as draft April 5, 2023 23:48
@julio-lopez
Copy link
Contributor Author

julio-lopez commented Apr 5, 2023

@viveksinghggits @pavannd1 Please DO NOT merge yet, it is not complete. I'd like to include an upgrade for Openshift's client-go module as well in the same PR.
Nevertheless, PTAL and LMK if there are any concerns.

Also, what is the plan for upgrading Openshift going forward if automatic upgrades don't work reliably?

@julio-lopez
Copy link
Contributor Author

Also, this includes a couple of minor upgrades to k8s dependencies. Those can be pushed separately in case we need to revert this change.

@julio-lopez julio-lopez marked this pull request as ready for review April 5, 2023 23:56
go.mod Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@julio-lopez
Copy link
Contributor Author

julio-lopez commented Apr 11, 2023

depends on #1862 #1992 #2005

Kanister automation moved this from In Progress to Reviewer approved Apr 11, 2023
@mergify mergify bot merged commit 9a237f7 into master Apr 11, 2023
Kanister automation moved this from Reviewer approved to Done Apr 11, 2023
@mergify mergify bot deleted the dep/openshift-4-15 branch April 11, 2023 23:40
julio-lopez added a commit that referenced this pull request Apr 13, 2023
This reverts commit 9a237f7.

It appears to break compatibility in downstream consumers.
mergify bot pushed a commit that referenced this pull request Apr 13, 2023
This reverts commit 9a237f7.

It appears to break compatibility in downstream consumers.
julio-lopez added a commit that referenced this pull request Apr 14, 2023
mergify bot pushed a commit that referenced this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants