Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against empty tags #200

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Guard against empty tags #200

merged 1 commit into from
Aug 13, 2019

Conversation

hakanmemisoglu
Copy link
Contributor

This PR adds a guard against empty tags.

AWS methods give error when an empty or empty content map are passed to tag-setting methods.
To fix this problem, we need to check the size of the map before passing the maps.

  • Adds a size check for setBackupTags.
  • Adds a size check for setEFSTags.

@hakanmemisoglu hakanmemisoglu merged commit b28b459 into master Aug 13, 2019
@pavannd1 pavannd1 deleted the efs-set-tag-fix branch August 13, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdmanv tdmanv tdmanv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hakanmemisoglu @tdmanv