Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(infra): add package write permissions to workflow #2000

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

julio-lopez
Copy link
Contributor

@julio-lopez julio-lopez commented Apr 10, 2023

Also, include additional metadata in the container image, including a git commit ref.

Pull request type

  • 🚧 Build infrastructure

Test Plan

  • πŸ’ͺ Manual
  • ⚑ CI

Sample image uploaded to GHCR https://github.com/kanisterio/kanister/pkgs/container/build/84282456?tag=sha-f599666

#1991

@github-actions
Copy link
Contributor

Thanks for submitting this pull request πŸŽ‰. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Apr 10, 2023
@julio-lopez
Copy link
Contributor Author

@pavannd1 @shahpratikr PTAL. I'll revert the last commit once CI passes. It was only used for testing. Then I'll merge the changes.

Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for doing this πŸ™πŸΌ

@jatk10 jatk10 enabled auto-merge (squash) April 11, 2023 01:23
@jatk10 jatk10 changed the title Add package write permissions to workflow build(infra): add package write permissions to workflow Apr 11, 2023
Kanister automation moved this from In Progress to Reviewer approved Apr 11, 2023
@jatk10 jatk10 merged commit 9a8a2ea into master Apr 11, 2023
Kanister automation moved this from Reviewer approved to Done Apr 11, 2023
@jatk10 jatk10 deleted the fix/workflow-perms branch April 11, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants