Add arg to connect to kopia repos as readonly #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new field to the repository and repository server connect arg structs to connect to a repository/server in read-only mode. As of kopia/kopia/#2799, there are new kopia workflows which require a read only connection.
|
@aaron-kasten kopia dependency in kanister needs to be bumped to kopia/kopia#2799 (kopia/kopia@c65613c) for this PR to make sense. There are downstream dependencies on this PR. |
|
Closing for now, as it is possible to get around this downstream |
|
@ankitjain235 or @aaron-kasten Can one of you drive merging this PR? |
|
@julio-lopez The Kopia commit we are referring to is after the one mentioned in the comment above. I don't see that PR needs any changes, and we can merge it as it is. cc @pavannd1 |
pavannd1
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This commit adds a new field to the repository and repository server connect arg structs to connect to a repository/server in read-only mode. As of kopia/kopia#2799, there are new kopia workflows which require a read only connection.
Pull request type
Please check the type of change your PR introduces:
Test Plan