Repository server controller not retrying again in case of failure #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
kale-amruta
requested review from
PrasadG193,
pavannd1,
viveksinghggits and
r4rajat
PrasadG193
reviewed
Apr 25, 2023
pkg/controllers/repositoryserver/repositoryserver_controller.go
Outdated
Show resolved
Hide resolved
r4rajat
reviewed
May 18, 2023
kale-amruta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The error while starting the repo server controller was getting overriden, hence the controller was not retrying the reconcilation
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan