Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kopia and other dependencies #2017

Merged
merged 7 commits into from
Apr 19, 2023
Merged

Conversation

aaron-kasten
Copy link
Contributor

@aaron-kasten aaron-kasten commented Apr 13, 2023

Change Overview

Upgrade Kopia tool and library dependency to latest v0.13.0-rc1

Pull request type

Please check the type of change your PR introduces:

  • 🌈 Refactoring (no functional changes, no api changes)

Issues

  • fixes #issue-number

Test Plan

  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

go.mod Outdated Show resolved Hide resolved
@pavannd1
Copy link
Contributor

@aaron-kasten Have you run go mod tidy -compat=1.19?
Error in the CI

stale go.mod and go.sum: please run `go mod tidy`

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@aaron-kasten
Copy link
Contributor Author

aaron-kasten commented Apr 18, 2023

Yes..

@aaron-kasten Have you run go mod tidy -compat=1.19? Error in the CI

stale go.mod and go.sum: please run `go mod tidy`

Yes. Absolutely. I'll see if there are some updates that show up with the command line -compat.

go mod tidy -compat=1.19 didn't come up with anything - No changes...

@pavannd1
Copy link
Contributor

pavannd1 commented Apr 19, 2023

I see this diff when I run go mod tidy -compat=1.19

index 9d704826..d19e1619 100644
--- a/go.mod
+++ b/go.mod
@@ -169,7 +169,7 @@ require (
        go.uber.org/multierr v1.11.0 // indirect
        golang.org/x/crypto v0.8.0 // indirect
        golang.org/x/exp v0.0.0-20221028150844-83b7d23a625f // indirect
-       golang.org/x/mod v0.8.0 // indirect
+       golang.org/x/mod v0.10.0 // indirect
        golang.org/x/net v0.9.0 // indirect
        golang.org/x/sync v0.1.0 // indirect
        golang.org/x/sys v0.7.0 // indirect
diff --git a/go.sum b/go.sum
index 0ca1bdf7..507fb332 100644
--- a/go.sum
+++ b/go.sum
@@ -571,8 +571,8 @@ golang.org/x/mod v0.2.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
 golang.org/x/mod v0.3.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
 golang.org/x/mod v0.4.2/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
 golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4/go.mod h1:jJ57K6gSWd91VN4djpZkiMVwK6gcyfeH4XE8wZrZaV4=
-golang.org/x/mod v0.8.0 h1:LUYupSeNrTNCGzR/hVBk2NHZO4hXcVaW1k4Qx7rjPx8=
-golang.org/x/mod v0.8.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
+golang.org/x/mod v0.10.0 h1:lFO9qtOdlre5W1jxS3r/4szv2/6iXxScdzjoBMXNhYk=
+golang.org/x/mod v0.10.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
 golang.org/x/net v0.0.0-20180724234803-3673e40ba225/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
 golang.org/x/net v0.0.0-20180826012351-8a410e7b638d/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
 golang.org/x/net v0.0.0-20180906233101-161cd47e91fd/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=

Do you want me to change the versions? go mod tidy -compat=1.19 makes no changes on my system.

@aaron-kasten
Copy link
Contributor Author

aaron-kasten commented Apr 19, 2023

@aaron-kasten Have you run go mod tidy -compat=1.19? Error in the CI

stale go.mod and go.sum: please run `go mod tidy`

go mod tidy -compat=1.19 makes no changes on my system.

Kanister automation moved this from In Progress to Done Apr 19, 2023
@aaron-kasten aaron-kasten reopened this Apr 19, 2023
Kanister automation moved this from Done to In Progress Apr 19, 2023
Copy link
Contributor

@julio-lopez julio-lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. See inline comment.
Somebody else should approve.

go.mod Outdated Show resolved Hide resolved
go.mod Outdated
@@ -67,6 +66,7 @@ require (
)

require (
github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v0.3.0 // indirect; pinned - current kopia build referenced here requires v0.3.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tidy ;)

Copy link
Contributor

@julio-lopez julio-lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge after CI passes. Thanks.

Kanister automation moved this from In Progress to Reviewer approved Apr 19, 2023
@aaron-kasten aaron-kasten added the dependencies Pull requests that update a dependency file label Apr 19, 2023
@pavannd1 pavannd1 added the kueue label Apr 19, 2023
@mergify mergify bot merged commit 328fbf4 into master Apr 19, 2023
Kanister automation moved this from Reviewer approved to Done Apr 19, 2023
@mergify mergify bot deleted the kopia-kanister-upgrade-rc1 branch April 19, 2023 23:47
@julio-lopez julio-lopez changed the title update dependencies Update kopia and other dependencies Apr 19, 2023
@julio-lopez
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file kueue
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants