Fix code generation command #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
PrasadG193
reviewed
Apr 14, 2023
pkg/client/clientset/versioned/typed/cr/v1alpha1/fake/fake_actionset.go
Outdated
Show resolved
Hide resolved
shahpratikr
force-pushed
the
pratik/fix_codegen
branch
from
45b952d
to
649f948
Compare
PrasadG193
reviewed
Apr 14, 2023
pavannd1
reviewed
Apr 14, 2023
pkg/client/informers/externalversions/cr/v1alpha1/repositoryserver.go
Outdated
Show resolved
Hide resolved
shahpratikr
force-pushed
the
pratik/fix_codegen
branch
from
649f948
to
31a483a
Compare
|
/ok-to-test |
|
@shahpratikr when I ran it locally, I also saw changes in |
@PrasadG193 Were there any other changes than the license changes we reverted above? |
|
I've included the changes in this PR - https://github.com/kanisterio/kanister/pull/2023/files#diff-8729adfad15910ec5613c5fa71a69d130b81e47f0b3ac39199074c992e20d7f7 |
shahpratikr
force-pushed
the
pratik/fix_codegen
branch
from
31a483a
to
b994930
Compare
|
added it |
PrasadG193
reviewed
Apr 18, 2023
PrasadG193
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR fixes
make codegencommand.Issue: Since we don't have
k8s.io/code-generatordependency in go.mod, we are missing with code-generator directory.Solution: Import empty code-generator package in
pkg/apis/cr/v1alpha1/docs.go. This will help in future to keep track of version change for code-generator package.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Manually ran
make codegencommand. It generated files successfully.